Raise nicer errors when legislation is invalid #742
Conversation
| legislation_tree, | ||
| state = conv.default_state, | ||
| ) | ||
| compact_legislation = tax_benefit_system.get_legislation(year) |
There was a problem hiding this comment.
What are we testing exactly ? @michelbl do you think it is relevant ?
I don't know much this part of OpenFisca.
There was a problem hiding this comment.
We are testing that the xml files can load. I think it is relevant, even if a lot of other tests load them.
| @@ -1,5 +1,11 @@ | |||
| # Changelog | |||
|
|
|||
| ### 18.2.2 - [#742](https://github.com/openfisca/openfisca-france/pull/742) | |||
There was a problem hiding this comment.
As you are not modifying the openfisca_france package, you don't need to publish a new version.
There was a problem hiding this comment.
Only the tests are changed. But CI will complain if I don't bump the version number ?
There was a problem hiding this comment.
The CI should not enforce a version bump if you haven't changed any file inside openfisca_france ;)
There was a problem hiding this comment.
However, on second thought, improving the error is a proper nice feature, so bumping the version number is legit.
CHANGELOG.md
Outdated
|
|
||
| * Amélioration technique | ||
| * Détails : | ||
| - Met à jour les tests sur la législation à la version `Openfisca-Core` `12.1.1`. |
There was a problem hiding this comment.
Du point de vue de l'utilisateur, ce qui change n'est pas l'adaptation des tests, mais l'amélioration du message d'erreur en cas d'erreur dans la législation.
CHANGELOG.md
Outdated
| @@ -2,9 +2,9 @@ | |||
|
|
|||
| ### 18.2.2 - [#742](https://github.com/openfisca/openfisca-france/pull/742) | |||
|
|
|||
| * Amélioration technique | |||
| * Amélioration de messages d'erreur | |||
There was a problem hiding this comment.
Presque : cette première ligne est normalisée : il n'y a que 4 valeurs possibles
Connected to openfisca/openfisca-core#474