New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1651/carbon footprint from meat #1656

Merged
merged 15 commits into from Feb 13, 2019

Conversation

Projects
None yet
4 participants
@stephanegigandet
Copy link
Contributor

stephanegigandet commented Feb 8, 2019

This is a new feature for the mobile app, to show an infocard about the carbon footprint from the meat or fish detected in the ingredients list. This bug has more details: #1651

The code is currently live on production (we are going to make a demo of that at the French national assembly on Tuesday). Corresponding products are being populated: https://fr.openfoodfacts.org/misc/en:environment-infocard

stephanegigandet added some commits Feb 7, 2019

Merge pull request #1654 from openfoodfacts/master
merge master into branch

@stephanegigandet stephanegigandet requested review from hangy and teolemon Feb 8, 2019

@teolemon

This comment has been minimized.

Copy link
Member

teolemon commented Feb 8, 2019

Can you copy the infocard to the field without language prefix ?

Show resolved Hide resolved lib/ProductOpener/Display.pm Outdated
Show resolved Hide resolved lib/ProductOpener/Food.pm
Show resolved Hide resolved lib/ProductOpener/Food.pm
Show resolved Hide resolved lib/ProductOpener/Food.pm Outdated
my $child = shift;
my $parent = shift;

#$log->debug("is_a", { tagtype => $tagtype, child => $child, parent => $parent }) if $log->is_debug();

This comment has been minimized.

@hangy

hangy Feb 9, 2019

Member

Commented log statements here and following lines.

This comment has been minimized.

@stephanegigandet

stephanegigandet Feb 9, 2019

Author Contributor

I still don't understand how to set the log level in product opener, what I put in log.conf seems to be ignored. How do I get debug messages in Apache's error log? (or in another file)

Show resolved Hide resolved po/common/common.pot
msgid "for one serving"
msgstr ""

msgctxt "methodology"

This comment has been minimized.

@hangy

hangy Feb 9, 2019

Member

Can we have additional context for translations? cc @teolemon

@CharlesNepote

This comment has been minimized.

Copy link
Contributor

CharlesNepote commented on 6be6fb9 Feb 12, 2019

Would you add a source? I'm unable to find it on Wikipedia for example. IMHO this sort of external data should be documented in the code (and even for the end-user).

@stephanegigandet

This comment has been minimized.

Copy link
Contributor Author

stephanegigandet commented Feb 13, 2019

@CharlesNepote : i haven't seen a reliable source either, it's just one figure that appears on some blogs etc. I'll make a note of that in the bug.

@stephanegigandet stephanegigandet merged commit a1c69cc into master Feb 13, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment