Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Standing Orders - improved order cycle duplication #1052
Order Cycles can currently be "cloned", which creates a brand new OC with identical settings.
The proposed Standing Orders model requires that Order Cycles exist into the future, as far as the shop owner wants customers to be allowed to place/cancel and ultimately edit their future orders.
In light of this, the capability to copy the list of products, fees and tags from between two existing order cycles becomes desirable.
referenced this issue
Jun 22, 2016
Hi @stveep, I think overwrite. From my perspective, the desired functionality is that the 'destination' OC looks exactly the same as the 'source' OC one the copy action has been completed. So I think it is basically just a wipe and rewrite. Does that sound ok?
Edit: I fixed my bug, which this post was really about, so never mind! I'll leave the implementation details here though:
A few details on the implementation:
You can find it on my fork here: https://github.com/stveep/openfoodnetwork/tree/1067-so-oc-duplication. I still need to add a few things.
There is also an authentication problem that I'm not sure how to fix - it works for a [super] admin user but not for a regular user at the moment. As noted on the PR, I couldn't get my feature test working (it's there but set to "pending") and this might be why. I won't have time to look until the weekend but it's probably an easy fix if you could have a look @oeoeaio ?
removed this from the [FEAT] Subscriptions (Standing Orders) milestone
Sep 15, 2017
This was referenced
Jul 5, 2018
If we go back to the need, what is it? The need is to enable hub manager to create easily a batch of OC attached to a schedule. To answer that need there are multiple possibilities:
I would say that given the scoped need described here https://community.openfoodnetwork.org/t/a-hub-manager-can-setup-an-automatic-standing-order-for-a-registered-customer/1462 this issue is out of scope so I will just close it for now.
When we get feedbacks from users saying it's not practical, we can open a wishlist about the need and investigate potential solutions and decide.
@kirstenalarsen I remember you suggested it also in some other GH issue some time ago, so if you have already feedbacks from users about it, please open a wishlist item and we can happily move it forward :-)
I think this is going to be a big issue for village centres - not because of subscriptions but because they are going to want order cycle every day and eventually lots of outgoing hubs - it will quickly become unworkable to open and manually change the delivery/pick-up info in each. But I will create a wishlist when confirmed :)…
On 23 Oct 2018, at 5:33 AM, Myriam ***@***.***> wrote: @daniellemoorhead <https://github.com/daniellemoorhead> if you disagree just SHOUT (gently of course ;-)) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1052 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACxryHdZQQOUxSTgWBgM6TdkoG-48HcHks5ung-GgaJpZM4I7RIZ>.
I think it should be separate and not included in standing order, but I can see the need and it definitely deserve a deeper thinking and UX reflexion a bit broader than just "make it easier to duplicate an OC"... so yes @kirstenalarsen open a wishlist and let's start to understand the need, and start some refined inception and see if we can prioritize sooner rather than later in the tons of things we want to priroitize :-) If you move forward inception chances are higher than the project move forward quicker :-)