New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private shop bug 2: delete a customer from your customer list impossible #1494

Open
myriamboure opened this Issue Mar 20, 2017 · 15 comments

Comments

Projects
7 participants
@myriamboure
Copy link
Contributor

myriamboure commented Mar 20, 2017

Following the issue #1493

> You should be able to delete a customer from your customer list regardless of whether they have placed orders in your shop.

I tried to delete the same customer from the customer list, and the system prevent me to delete it from the hub's customer list... it says there are orders associated (even if the user has never accessed the shopfront see the other github issue) and even if they were, as a hub manager I need to be able to delete a customer from my customer list (it shouldn't delete it as a customer on the OFN, just take it out of the hub list)

@myriamboure myriamboure added the france label Mar 20, 2017

@myriamboure

This comment has been minimized.

Copy link
Contributor

myriamboure commented Mar 20, 2017

@lin-d-hop

This comment has been minimized.

Copy link
Contributor

lin-d-hop commented Apr 24, 2017

The solution to #1457 should also cover this...

@myriamboure

This comment has been minimized.

Copy link
Contributor

myriamboure commented May 3, 2017

Hum... it will partly solve it @lin-d-hop , but not really. Let's say member A is member of the buying groups for one year, but stop being a member. The buying group who manages a private shop want to remove this user so that he doesn't have access anymore (or the hub should use a tag method but then the private shop feature is no point...) So for me if a hub want to remove a user with existing orders, he should be able to do it the existing orders should just stay as they were, a bit like when you remove a product, the existing orders with the product stay as they were... of course if existing order maybe a warning pop-in with "are you sure" is a good idea.

@jeronimo

This comment has been minimized.

Copy link
Contributor

jeronimo commented May 4, 2017

I think there was a serious reason to bind customer with order in a such stiff way. @lin-d-hop, maybe someone can help us identify why was that and if we can make it not that strong?

@myriamboure

This comment has been minimized.

Copy link
Contributor

myriamboure commented Dec 21, 2017

@lin-d-hop I think we need to keep the "bug" label as the private shop feature won't be usable without this... We already have hubs who have people in their customer list because they made tests, and then set up the shop as private but they don't want those people to access the shop... for me it's breaking the feature if you can't control who have access to your private shop.
In that sense I would use the same severity 2 tag as private shop bug 1 (connected to email confirm) as unfortunately I don't see any workaround, appart from asking a dev to hard delete the user from DB :-o
But of course happy to hear what you thought about it :-)

@myriamboure myriamboure removed the bug label Dec 21, 2017

@sauloperez

This comment has been minimized.

Copy link
Contributor

sauloperez commented Jan 3, 2018

As a severity 2 bug it should be worked on next as soon as any dev is available. Is that what we want?

@myriamboure

This comment has been minimized.

Copy link
Contributor

myriamboure commented Jan 7, 2018

Yep, right @sauloperez ! There are probably various way to address that issue though (various candidates):

  • do we just enable to delete the customer from the customer list (but the customer still exist in the system, no impact on previous orders, etc, just invisible from customer list view and no access to the shop for the given customer)
  • or do we want the hub to be able to keep all the customer list but "tag" in some way those who can access the shop?
    I guess the first step resolution which will solve the bug and so enable to use the initial private shop feature is just to be able to delete the customer. And probably the feature can be improved later on. So my proposal would be to keep it simple for now, but just wanted to make sure the bug fix is acceptable as is.
@sauloperez

This comment has been minimized.

Copy link
Contributor

sauloperez commented Jan 9, 2018

So my proposal would be to keep it simple for now

❤️

@HugsDaniel

This comment has been minimized.

Copy link
Contributor

HugsDaniel commented Feb 19, 2018

Someone working on this one @myriamboure ? I could take a look.

@myriamboure

This comment has been minimized.

Copy link
Contributor

myriamboure commented Feb 19, 2018

Would be great @HugsDaniel ! I don't think there is any connexion with "soft delete" here as it's just removing from view from hub manager and removing access, it's not really deleting anything.

I feel though that we need some consent from the community about the solution we propose as step one:
1- a hub manager can "remove" a customer from his customer list, so then the customer doesn't have access anymore to the shop. This solve the private bug issue. But it means also that the hub manager loose track of this ex-customer information, we need to be aware of that. It's a quick fix to the bug, but is not ideal in term of user customer management (like if the customer wants to shop again the manager wouldn't know he has shoped before). Are we ok though to start with that quick fix before we work on improving customer management as a whole? Of course old orders from the given customers will still be there.
2- else we need a speccing session to decide what we want...
@daniellemoorhead @sstead @lin-d-hop @sauloperez @enricostano @sigmundpetersen would be great to have your consent on solution one...

@enricostano

This comment has been minimized.

Copy link
Contributor

enricostano commented Feb 20, 2018

I think it's too early to start working on this. Let's talk about it in the curation team kick-off and look at priorities.

@daniellemoorhead

This comment has been minimized.

Copy link

daniellemoorhead commented Feb 22, 2018

@myriamboure and @enricostano now that we've prioritised sev 1 and 2 bugs to be fixed shall we kick off determining a design/solution for this? Is this something you all can manage over there?

@enricostano

This comment has been minimized.

Copy link
Contributor

enricostano commented Feb 22, 2018

@daniellemoorhead tomorrow with @myriamboure we'll go through s1 and s2 and will see if we need some help. In this specific case we will since the solution that is in the air (soft deletion) is part of a bigger sicussion that we still need to have.

@myriamboure

This comment has been minimized.

Copy link
Contributor

myriamboure commented Feb 23, 2018

After discussing with @enricostano this morning we agreed that this was not a bug but just the feature was not very well designed. So we created an icebox "hubs can decide who accesses their private shop" https://community.openfoodnetwork.org/t/hubs-can-decide-who-accesses-their-private-shop/1236 and this will go through the priorization process. Also started to list feature candidates, please feel free to add some on the thread if you have other ideas.

@myriamboure myriamboure removed their assignment Feb 23, 2018

@myriamboure

This comment has been minimized.

Copy link
Contributor

myriamboure commented Jan 17, 2019

Given discussions here https://community.openfoodnetwork.org/t/hubs-can-block-shoppers-decide-who-accesses-their-private-shop/1236/12 we agreed that it is a bug and reopen it. We leave it s3 and as mentioned by Theresa in the discussion it blocked onboarding of 2 hubs. So let's fix it to make the private shop feature fully work.

@myriamboure myriamboure reopened this Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment