Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable different fees to be charged based on tag used #1824

Closed
myriamboure opened this issue Sep 12, 2017 · 6 comments

Comments

@myriamboure
Copy link
Contributor

commented Sep 12, 2017

@myriamboure

This comment has been minimized.

Copy link
Contributor Author

commented Oct 6, 2017

It seems that Sally validates our approach, so I sum up here the spec (= option 1 in this post of the discussion) :

Following the "default rule" and "tag rule" logic, we need :

  • to be able to tag an enterprise fee: add a column "tag" in the "enterprise fee" table, like the one already in the "inventory table" for instance. [There are some display issue on the entreprise fee table, we can't see the name when typing it, but I'll treat that in a separate issue, low priority)
    screenshot from 2017-10-06 16-51-47
    screenshot from 2017-10-06 16-53-30

  • create the rule that makes it possible to tell if customer and entreprise fee as the same tag, if this tag, entreprise fee is "applicable" or "non applicable"

discount tag
fee2

  • and of course make sure that the rule works well, and the calculation are happening properly with the good entreprise fees being charged according to the good tag of the customer :-)

Things to check:

make sure we can create mutiple tag rules on the same tags and type base (I think it should be ok logically)
if a user tag is removed later on, we need to make sure it doesn't change the history in the past orders... I guess that's ok but just to keep in mind. And useful for testing notes ;-)

@myriamboure

This comment has been minimized.

Copy link
Contributor Author

commented Oct 6, 2017

Ok so following the discourse discussion I specified the work to do. Please @kirstenalarsen or @oeoeaio if you have anything to add on that go ahead, we want to launch asap, for our big cooperative food hub that we love :-)

@myriamboure myriamboure added this to Wait - in discussion in France Current Oct 6, 2017

@myriamboure

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2017

Precision: the tag rule concerns any enterprise fee, whether it be at coordinator, incoming or outgoing level.

@oeoeaio

This comment has been minimized.

Copy link
Contributor

commented Oct 12, 2017

Sorry for my slow response @myriamboure. I must have missed the previous notification email.

I haven't done any deep investigation into this, but my first thought is that applying fees to products based on a customer tag will require a different approach to loading product information into the shop. At the moment, price information is cached along with all other product information, so that large numbers of products can be loaded quickly into the shop. If we want to change product prices based on the tags that have been applied to the customer, then we will need to regenerate prices for all products each time the shop is loaded. As I said, I haven't investigated this thoroughly, but I think this part is likely to be the most difficult component of the work.

I think the rest of the spec looks great.

@myriamboure

This comment has been minimized.

Copy link
Contributor Author

commented Oct 12, 2017

Thanks @oeoeaio for your comments, I guess we should be cautious in not increasing the loading time through that process. We'll investigate first on that.

@myriamboure myriamboure moved this from Wait - in discussion to Dev Estimate in France Current Oct 12, 2017

@myriamboure myriamboure removed the aus review label Oct 30, 2017

@myriamboure

This comment has been minimized.

Copy link
Contributor Author

commented Dec 19, 2017

@myriamboure myriamboure removed this from Dev Estimate & Inception in France Current Dec 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.