New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscriptions v1 #2077

Open
daniellemoorhead opened this Issue Feb 9, 2018 · 7 comments

Comments

@daniellemoorhead
Copy link
Contributor

daniellemoorhead commented Feb 9, 2018

[Updated by Myriam 22.10.2018]

Original description of the problem this feature is solving

https://community.openfoodnetwork.org/t/a-hub-manager-can-setup-an-automatic-standing-order-for-a-registered-customer/1462

Description of the feature

Big overview of how it works:

  • hub manager can set up the recurring order, pause or cancel. If start date is before OC end date, order is made for the OC. If end date is before OC end date, no order is made for the OC.
  • when OC starts, customer receives an email saying an order has been made on her behalf (can amend, if hub authorize it)
  • when OC closes, customer receives an email saying the order has been confirmed and can’t be modified anymore

Story map

Most user stories have been realized now, and after an end to end check, we are just listing in this epic now the last remaining bugs and big UX issues so that we can consider the feature as done.

You can get a view of all the remainin issues and bugs via the github project for this: https://github.com/openfoodfoundation/openfoodnetwork/projects/15

@daniellemoorhead daniellemoorhead changed the title Subscriptions: The all-encompassing epic that allows you to find all the things Subscriptions v1 Feb 9, 2018

@enricostano

This comment has been minimized.

Copy link
Contributor

enricostano commented Feb 22, 2018

@daniellemoorhead @oeoeaio any task to deal with translations before we go live with subscriptions?

@sstead

This comment has been minimized.

Copy link

sstead commented Feb 23, 2018

Testing Feedback @oeoeaio

issues found:

  • Email issues when a subscription has items in it that are not in the OC
  • There's no information about the shipping method in the email confirmations going to subscribers who pay with Stripe
  • Emails to the shop owner are sometimes not sent
  • Email not sent when an edited subscription order is first actiated
  • Messaging isn't that clear when the manager starts or un-pauses a subscription mid way through open OC

https://docs.google.com/document/d/1GB9j6ks0FPVBu_pnqgOCuH9jUbjBzFBy5UhAfURT8Hs/edit?usp=sharing

@oeoeaio

This comment has been minimized.

Copy link
Contributor

oeoeaio commented Mar 2, 2018

@enricostano I assume we just treat translations for this feature in the same way as we treat other translations. Is there any particular reason that this is a special case?

@daniellemoorhead daniellemoorhead added this to In progress (kicked-off) in Product Feature Backlog Mar 2, 2018

@enricostano

This comment has been minimized.

Copy link
Contributor

enricostano commented Mar 7, 2018

@enricostano I assume we just treat translations for this feature in the same way as we treat other translations. Is there any particular reason that this is a special case?

You're right, right now we have that strategy. I'm only wondering if all the instances are aware of the coming changes and that maybe they want to wait to deploy the release that will include this feature so they can translate the new keys first and then deploy the next (really near) release.

Ignore me, I'm just trying to understand if that rule is OK for all the cases or we need to be careful in some case. 😅

@daniellemoorhead

This comment has been minimized.

Copy link
Contributor Author

daniellemoorhead commented Mar 9, 2018

I hear you @enricostano and I think this is an opportunity for us to mature as a software development group to ensure that what we build is considered in the context of implementation. It makes me happy that this feature is currently hiding behind a toggle, I'm of the belief that this is good practice for any new feature we decide to build.

And perhaps we need to include consideration within our product development process about how to launch? We've done that with Subs (see the slack channel for that detail), but perhaps having it within the process will be of benefit in terms of consistency?

@daniellemoorhead daniellemoorhead changed the title Subscriptions v1 Subscriptions v1 [beta] Aug 30, 2018

@sigmundpetersen sigmundpetersen changed the title Subscriptions v1 [beta] Subscriptions v1 [beta] [Parent epic] Aug 30, 2018

@daniellemoorhead daniellemoorhead changed the title Subscriptions v1 [beta] [Parent epic] Subscriptions v1 [beta] Sep 11, 2018

@daniellemoorhead daniellemoorhead moved this from In progress (kicked-off) to Review ready (problem solved?) in Product Feature Backlog Oct 4, 2018

@myriamboure myriamboure moved this from Review ready (problem solved?) to In progress (kicked-off) in Product Feature Backlog Oct 18, 2018

@myriamboure

This comment has been minimized.

Copy link
Contributor

myriamboure commented Oct 22, 2018

I'm closing this epic in the cleaning process I'm doing and will open a new one with the remaining things for standing order / subs feature to be consider as done.

@myriamboure

This comment has been minimized.

Copy link
Contributor

myriamboure commented Oct 22, 2018

I'm reopening it so we can keep track of all the past thing and not loose connexion. I'm just adding to the epic the last issues in the board project. Ideally I should have created a last sub epic, but now that there are no more sub epic it's ok to attach them directly I guess.

@myriamboure myriamboure reopened this Oct 22, 2018

@myriamboure myriamboure changed the title Subscriptions v1 [beta] Subscriptions v1 Oct 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment