Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a user has items in cart and hub remove them from OC, he can still proceed to checkout and buy them #2091

Closed
myriamboure opened this issue Feb 20, 2018 · 5 comments

Comments

5 participants
@myriamboure
Copy link
Contributor

commented Feb 20, 2018

Description

A user can buy items that were removed/deleted from an order cycle if they had those products in their cart before retrieval.

Expected Behavior

If at checkout time some products I have in my cart have become unavailable because removed from the OC by the manager, I should not be able to checkout and be sent back to my cart with an error message on the given item saying they became unavailable and prompting me to modify my cart.

Actual Behavior

If at checkout time some products I have in my cart have become unavailable because retrieved from the OC by the manager, I am still able to buy them.

Steps to Reproduce

  1. In browser A, user A put in his cart x quantity of item y. He is ready to checkout but has not yet clicked on the last step of the checkout.
  2. At that precise moment, the shop manager modify this very same order cycle and remove the given item OR producer from the order cycle, and save the change.
  3. After that, user 1 click on the last step of his checkout and manage to proceed and buy the product.

Animated Gif/Screenshot

https://www.useloom.com/share/4dcbfb6a0025435ea4014a0780921050

Context

We reported while working on #1491 as part of the job for new feature #1031 persistent cart.

Severity

s3 or s2 (to be discussed, putting s3 for now)

Your Environment

  • Version used: 1.10.1
  • Browser name and version: Version 64.0.3282.167 (Official Build) (64-bit)
  • Operating System and version (desktop or mobile): Ubuntu 16.04 LTS

Possible Fix

An attempt was made on #1767 but was not complete.

@myriamboure myriamboure added the bug-s3 label Feb 20, 2018

@enricostano enricostano added bug-s2 and removed bug-s3 labels Feb 23, 2018

@myriamboure myriamboure changed the title If a user has items in cart and hub retrieve them from OC, he can still proceed to checkout and buy them If a user has items in cart and hub remove them from OC, he can still proceed to checkout and buy them Mar 4, 2018

@openfoodfoundation openfoodfoundation deleted a comment from mkllnk Mar 4, 2018

@sauloperez

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2018

It might not be a good idea to work on this until we reach a stable point with Spree 2.0. It's the area of Spree we overrode the most and there might be 🐉 🐉

@sauloperez sauloperez added the blocked label Mar 15, 2018

@myriamboure myriamboure added this to Blocked in Bug management Jul 14, 2018

@sigmundpetersen

This comment has been minimized.

Copy link
Contributor

commented Aug 24, 2018

Is this really a part of Spree Upgrade epic or is it just blocked by it?

@luisramos0

This comment has been minimized.

Copy link
Contributor

commented Aug 24, 2018

This is blocked by spree upgrade but it is not part of it. This will be looked at after the upgrade. I have removed the spree2 epic from this issue.

@luisramos0

This comment has been minimized.

Copy link
Contributor

commented Mar 23, 2019

Removing the reference to #2109 and moving it to epic #2584 (all the issues blocked by the spree upgrade).

@luisramos0

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

I have tested this in v2 and it is still a problem.
Actually, imo if it was just at checkout time it would be an S3 because it would only happen in case user is actually checking out and hub manager doing it in the backoffice BUT when the product is removed from the OC, the product disappears from the shop list but not from the cart. So, if the user comes back the next day to her cart, it will still be able to checkout the product removed from the OC the day before. So definitely an S2.

This is not blocked by spree upgrade any more.

I will investigate, the solution may not be too difficult.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.