New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Subscriptions] If I edit a subscription while open, I can go into negative stock levels #2505

Open
sstead opened this Issue Jul 27, 2018 · 5 comments

Comments

5 participants
@sstead
Copy link

sstead commented Jul 27, 2018

Description

I'm a shop manager and I have an open order cycle with open subscription orders attached. A product is on zero stock. I edit one of the open susbcriptions, to add this item to the subscription. The stock level goes into negative values, even though my instance is set to not allow backorders. The sub order will be confirmed with this product in it at the close of the OC.

Expected Behavior

The item should be added to the susbcription, but there's insufficient stock, so the customer should get 0 QTY.

Actual Behavior

Rather than the customer getting 0 QTY of the product that was added to their subscription, they get the amount that was added, but the stock level goes into -ve values.

Steps to Reproduce

  1. Setup a shedule OC with an open subsccription in it.
  2. Set the on hand value of a product that's not in the susbcription to zero.
  3. Now edit this susbcription and add the product with zero stock to it.
  4. See if the stock level goes to -ve.
  5. You'll see the order get confirmed as though there was enough stock on hand, when really the order should have 0 QTY for that item.

Animated Gif/Screenshot

https://www.useloom.com/share/b164f07ce7984eaf8cdd09c2c725eb1c

Context

This could arise when subs is used broadly. We need to be confident that the stock control functionality isn't compromised because it's a central OFN feature.

Severity

s2

Your Environment

Staging1
PC Chrome

Possible Fix

Ensure that stock level is checked when a sub is edited, if stock level is zero, the sub order should have 0 QTY and insufficient stock messaging.

@sstead sstead added the bug-s2 label Jul 27, 2018

@myriamboure myriamboure added this to Dev ready in Bug management Jul 27, 2018

@daniellemoorhead

This comment has been minimized.

Copy link
Contributor

daniellemoorhead commented Sep 11, 2018

@sstead this is listed as a severity 2 bug yet it hasn't come up in our conversations about what needs to be completed for subscriptions to be "done" for now.

Is this actually an s2? Is it needed? Any s2 bugs are supposed to be picked up as a priority...yet this one seems to have slipped through without being noticed....

What should we do with it?

@sstead

This comment has been minimized.

Copy link
Author

sstead commented Sep 11, 2018

Eeep sorry. Yes this needs fixing, before subs is used more widely. Its not super likely to occur (maybe a case for s3) but it’s a bug in a core feature (stock control) so could also be s2?

@daniellemoorhead

This comment has been minimized.

Copy link
Contributor

daniellemoorhead commented Sep 11, 2018

@kirstenalarsen @myriamboure @RachL what do you think? Worthy of an s2? Should be fixed ASAP?

@kirstenalarsen

This comment has been minimized.

Copy link
Contributor

kirstenalarsen commented Sep 11, 2018

i think s3 - not catastrophic if it does happen, they can workaround / amend order, likely only a few - I'd say s3

@daniellemoorhead daniellemoorhead added bug-s3 and removed bug-s2 labels Sep 11, 2018

@sigmundpetersen sigmundpetersen changed the title Subs: If I edit a subscription while open, I can go into negative stock levels [Subs] If I edit a subscription while open, I can go into negative stock levels Sep 27, 2018

@sigmundpetersen sigmundpetersen changed the title [Subs] If I edit a subscription while open, I can go into negative stock levels [Subscriptions] If I edit a subscription while open, I can go into negative stock levels Oct 19, 2018

@myriamboure myriamboure added this to Design and define in Subscriptions Oct 22, 2018

@myriamboure myriamboure moved this from Design and define to Ready in Subscriptions Oct 22, 2018

@kristinalim

This comment has been minimized.

Copy link
Member

kristinalim commented Dec 27, 2018

Estimated time: 2 hours

This seems related to #2507. In addition to the time needed for that, estimating 2 hours for this.

@myriamboure myriamboure removed the bug-s3 label Jan 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment