Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
[Subscriptions] If I edit a subscription while open, I can go into negative stock levels #2505
I'm a shop manager and I have an open order cycle with open subscription orders attached. A product is on zero stock. I edit one of the open susbcriptions, to add this item to the subscription. The stock level goes into negative values, even though my instance is set to not allow backorders. The sub order will be confirmed with this product in it at the close of the OC.
The item should be added to the susbcription, but there's insufficient stock, so the customer should get 0 QTY.
Rather than the customer getting 0 QTY of the product that was added to their subscription, they get the amount that was added, but the stock level goes into -ve values.
Steps to Reproduce
This could arise when subs is used broadly. We need to be confident that the stock control functionality isn't compromised because it's a central OFN feature.
Ensure that stock level is checked when a sub is edited, if stock level is zero, the sub order should have 0 QTY and insufficient stock messaging.
@sstead this is listed as a severity 2 bug yet it hasn't come up in our conversations about what needs to be completed for subscriptions to be "done" for now.
Is this actually an s2? Is it needed? Any s2 bugs are supposed to be picked up as a priority...yet this one seems to have slipped through without being noticed....
What should we do with it?