New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt person to login if they use a link to an order and they are not logged in already. #2506

Closed
sstead opened this Issue Jul 27, 2018 · 4 comments

Comments

5 participants
@sstead
Copy link

sstead commented Jul 27, 2018

Description

If someone tries to access their order via a link of this format while logged out... https://staging1.openfood.com.au/orders/R244060841 ... they currently see an 'unauthorised' message.
image
Instead of this, could we prompt them to login?

This is important for subscriptions, because a big part of susbcriptions is that customers are able to edit their subs. If they're logged out when they try to edit their sub order, they'll get this confusing and abrupt 'unauthorised' message.

When does this scenario occur?
The first subscription conf email that goes to subscription customers.
image
This only occurs when a shop allows customers to make changes to their order while the OC is open.

Expected Behavior

The person is prompted to login. After logging in they're either a) taken to the order page if they're the right cusotmer or b) they see the unauthorised message again if it's not the right user for that order.

Alternatively I'd expect to see better messaging, like: 'unauthorised, please login to view this page'.

Actual Behavior

The person clicks the link.
They see this:
image
If they do have the initiative to login, they'll then see the order page. But there's no clear messaging that they need to login.

Steps to Reproduce

  1. Setup a subscription in a shop which allows changes to be made
  2. Open a subscription order and look at the email confirmation
  3. Try to open that link in a browser window where you're not logged in.

Animated Gif/Screenshot

Context

It's a road block for customers who want to edit a sub order

Bug Severity

s3

Your Environment

PC Chrome, Staging1.

@myriamboure

This comment has been minimized.

Copy link
Contributor

myriamboure commented Jul 27, 2018

Waiting for decision to be taken in #2508, so not yet in dev ready.

@myriamboure myriamboure added this to Analysis and design in Bug management Jul 27, 2018

@myriamboure myriamboure added bug-s2 and removed bug-s3 labels Jul 27, 2018

@myriamboure

This comment has been minimized.

Copy link
Contributor

myriamboure commented Jul 27, 2018

Changing bug level to s2 as well as from my understand we have done a soft release of subscription (am I right?) and this bug is preventing to basically use the feature and I don't see a workaround. But still in "analyse and define" as the solution is still under discussion, there are various options.

@kirstenalarsen

This comment has been minimized.

Copy link
Contributor

kirstenalarsen commented Jul 30, 2018

the only workaround is telling them somehow (hub email) that they need to go up to the menu and login. I agree it's likely to prevent people accessing their orders and fine with upgrade to s2.

@oeoeaio @sstead and I discussed this a bit - I think what we came up with was

  1. IDEAL: Open the login panel if they are not logged in.
  • If they login as correct user, direct them to the correct order page
  • If they were to login as incorrect user - take them to my orders? poss. with notification
  1. INTERIM? Change the 'unauthorised' message so that it prompts a login . . this is more satisfactory if EITHER
  • #2508 done as it ensures that they WILL have a login and therefore we don't need to deal with case of not having an existing user OR
  • #2511 done as it ensures that newly created and logged in User will be able to see the orders created by the subscription
@kirstenalarsen

This comment has been minimized.

Copy link
Contributor

kirstenalarsen commented Jul 30, 2018

either #2508 or #2511 to make manageable within Subs v1

@daniellemoorhead daniellemoorhead moved this from Dev Ready to Doing in Subscriptions Aug 10, 2018

@daniellemoorhead daniellemoorhead moved this from Doing to Dev Ready in Subscriptions Aug 10, 2018

@sstead sstead removed the bug-s2 label Aug 17, 2018

@daniellemoorhead daniellemoorhead removed this from Analysis and design in Bug management Aug 17, 2018

@sstead sstead added the bug-s3 label Aug 17, 2018

@sigmundpetersen sigmundpetersen moved this from Ready to In Progress in Subscriptions Sep 6, 2018

@sigmundpetersen sigmundpetersen moved this from In Progress to Code Review in Subscriptions Sep 7, 2018

@daniellemoorhead daniellemoorhead moved this from Code Review to In Progress in Subscriptions Sep 7, 2018

Subscriptions automation moved this from In Progress to Closed Sep 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment