Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Subs: connect existing Subscription and Orders with User created after them #2511
There are a complex of issues connected to the case where a Hub adds a Customer that is not an existing confirmed OFN user, and then creates a Subscription for them. When the Customer tries to click the link to access their order they can't as they're not an OFN user. (#2506 will improve messaging and action on that link)
#2508 suggests that this case should be prevented by not allowing creation of a Subscription without a confirmed OFN User already existing.
This Issue 'floats' a possible alternative response in which the Subscription can be created but the Customer needs to sign up and/or login to view or change their Orders.
A Hub creates a Customer who is not already a user on OFN. The Hub then creates a Subscription for that Customer.
When the Order is generated, the email confirmation link brings up login / sign-up panel (#2506). The Customer must sign-up / login to be able to view or edit their order
When the Customer signs up they will receive an email confirmation, they need to validate their email, then a User is created.
The system must then MATCH / reassign any existing 'guest' orders to that new User so that when they login / use the link in their email again they can see the orders created for their guest Customer before they had a User.
The Customer can create a User but pre-existing orders cannot be viewed or edited - they are lost in cyberspace.
Steps to Reproduce
S2 - either this or #2508 needs to be resolved for Subscriptions V1 to be useable
This was referenced
Jul 30, 2018
We talked about connecting guest orders and newly signed up users before. The problem is that we can't assume that all guest orders for one email address actually belong to the same person. Email addresses can change owners like phone numbers.
There are many solutions to this problem, but the best solutions are also a lot of work. If you want a quick fix, it would be easy to not allow subscriptions for guests or don't tell them that they can edit their order (hide that text for guests). In version 1, the subscription is set up and changed via the shop manager anyway. So it would be reasonable to call or email the manager to change the order, I think.
Thanks @mkllnk and BANG I reckon you hit on a workable solution there - @sstead @myriamboure what do you think of Maikel's idea - just remove the text and link about amending your order if they do not have a confirmed user?
Gets rid of this problem for now and options in #2508 can be considered in Subs next steps?
OK it seems the same conversation is happening in 3 GH issue, it's a bit hard to follow... @kirstenalarsen I understand your will to fix ASAP to make v1 work and have no objection if you want to remove the link about amending your order for unconfirmed users. But I'm also aware that on a longer term, if the user finally creates an account, their past orders will never be associated for any of the automatic orders made before. So IMO we are creating problems for the future. I think the more we get out of the possibility to let people make orders as guest and the quicker we do it, the less problems we will have in the future. I think I would rather trigger a confirmation email as soon as a subscription is created for a user and make sure no subscription can be made for shoppers who are not users. It might not be such a big work... did you discuss that option with @oeoeaio and Tshirt sized it?
It feels messy (in terms of being able to tell shop keepers and customers what to expect regarding viewing/editing subs) but if others like this approach, I support it as a short term thing.…
________________________________ From: Kirsten Larsen <email@example.com> Sent: Monday, July 30, 2018 2:06:53 PM To: openfoodfoundation/openfoodnetwork Cc: Sally; Mention Subject: Re: [openfoodfoundation/openfoodnetwork] Subs: connect existing Subscription and Orders with User created after them (#2511) Thanks @mkllnk<https://github.com/mkllnk> and BANG I reckon you hit on a workable solution there - @sstead<https://github.com/sstead> @myriamboure<https://github.com/myriamboure> what do you think of Maikel's idea - just remove the text and link about amending your order if they do not have a confirmed user? Gets rid of this problem for now and options in #2508<#2508> can be considered in Subs next steps? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#2511 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AKVzsIrw4FeIKlHXIaMNG3tQuvcx0Vhsks5uLoZdgaJpZM4VlrZD>.
There are two tasks here:
referenced this issue
Aug 10, 2018
ok. So I think we agree that this as specified above is not the correct solution for this problem. I am: