New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Subs] Remove link to 'make changes' to order from confirmation email if customer is guest #2534

kirstenalarsen opened this Issue Aug 10, 2018 · 0 comments


4 participants
Copy link

kirstenalarsen commented Aug 10, 2018


#2508 described a problem of invalid link / unauthorised when subscription created for a guest i.e. Customer that is not confirmed OFN user


Expected Behavior

This card replaces #2508 and #2511 - both of which outline more complex / effective improvements for consideration in next version of Subscriptions.

Expected behaviour for this 'quick fix' is that a guest Customer that does not have an OFN User does not have the 'make changes' link in their order confirmation email - so they cannot click on 'Make changes'. This Customer is not able to edit their order.

If they create a User later, they will be able to see orders created after that point, but not previous ones - they are lost forever.

NB. When this is done User Guide AND instance managers supporting Beta Subscriptions Users need to make sure they're aware that Customers who aren't OFN users will not be able to edit their orders.

Actual Behavior

An Enterprise can create a Customer without creating a User.
This means that they can then create a Subscription for a Customer that is not a User.
This means that when that subscription is turned into an order, the Customer receives an email telling them their order has been created and gives them a link to edit their order.
When they hit that link they get an 'unauthorised' page. If they then sign up (creating a User) and log in, they will be able to see new orders created but not old ones

To avoid this problem, a Hub would need to ensure that all their Customers have created User accounts before they can set up a Subscription for them. This is onerous and error-prone and will likely prevent people using Subscriptions at all. Way too many places to get interrupted / blocked and never complete the process.

Steps to Reproduce

  1. Create a new Customer from admin/customers - use a 'virgin' email that doesn't already have a User in OFN
  2. Create a Subscription for that Customer
  3. Click on the 'make changes' link in order confirmation
  4. See 'unauthorised' screen


Testing Subscriptions as a person new to it, got completely tangled. Potentially very off-putting to Subscription beta testers

Possible Fix

Change order confirmation text for a Customer that is not an authorised OFN user

Current text "This order was automatically created for you. You can [make changes] until orders close on Fri Aug 31 @ 12:00AM. If you have any questions you can contact VT Organic Bulk Buy via"

For Guest orders "This order was automatically created for you. You can make changes until orders close on Fri Aug 31 @ 12:00AM by contacting your Hub via hub@email."

Hub can then explain to them that they can sign-up if they want to be able to make changes themselves for future orders

@kirstenalarsen kirstenalarsen added this to Dev Ready in Subscriptions Aug 10, 2018

@sstead sstead removed the bug-s3 label Aug 17, 2018

@daniellemoorhead daniellemoorhead changed the title Subs: Remove link to 'make changes' to order from confirmation email if customer is guest [Subs] Remove link to 'make changes' to order from confirmation email if customer is guest Aug 20, 2018

@daniellemoorhead daniellemoorhead moved this from Ready to In Progress in Subscriptions Aug 30, 2018

@mkllnk mkllnk closed this in #2624 Sep 3, 2018

Subscriptions automation moved this from In Progress to Closed Sep 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment