Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
[Subs] Remove link to 'make changes' to order from confirmation email if customer is guest #2534
#2508 described a problem of invalid link / unauthorised when subscription created for a guest i.e. Customer that is not confirmed OFN user
Expected behaviour for this 'quick fix' is that a guest Customer that does not have an OFN User does not have the 'make changes' link in their order confirmation email - so they cannot click on 'Make changes'. This Customer is not able to edit their order.
If they create a User later, they will be able to see orders created after that point, but not previous ones - they are lost forever.
NB. When this is done User Guide AND instance managers supporting Beta Subscriptions Users need to make sure they're aware that Customers who aren't OFN users will not be able to edit their orders.
An Enterprise can create a Customer without creating a User.
To avoid this problem, a Hub would need to ensure that all their Customers have created User accounts before they can set up a Subscription for them. This is onerous and error-prone and will likely prevent people using Subscriptions at all. Way too many places to get interrupted / blocked and never complete the process.
Steps to Reproduce
Testing Subscriptions as a person new to it, got completely tangled. Potentially very off-putting to Subscription beta testers
Change order confirmation text for a Customer that is not an authorised OFN user
Current text "This order was automatically created for you. You can [make changes] until orders close on Fri Aug 31 @ 12:00AM. If you have any questions you can contact VT Organic Bulk Buy via firstname.lastname@example.org."
For Guest orders "This order was automatically created for you. You can make changes until orders close on Fri Aug 31 @ 12:00AM by contacting your Hub via hub@email."
Hub can then explain to them that they can sign-up if they want to be able to make changes themselves for future orders