Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spree Upgrade] Inventory cannot update price #3715

Closed
lin-d-hop opened this issue Apr 9, 2019 · 4 comments

Comments

Projects
None yet
3 participants
@lin-d-hop
Copy link
Contributor

commented Apr 9, 2019

Description

Tamar Valley Food Hub (TVFH) has permission to add Berio Mill to their inventory. When I open TVFH inventory I see the list for Berio Mill correctly. However when I try to update the price I get the following error:
"I couldn't get authorisation to save those changes, so they remain unsaved."

Expected Behavior

The changes to the price in inventory should save correctly and then should follow through to a change in price in the shopfront - as they currently do in v1.

Actual Behaviour

Error and no price update.

Steps to Reproduce

  1. Open Inventory for TVFH on FR staging
  2. Update a price eg Cornish Ale Mustard for Berio Mill
  3. See the error "I couldn't get authorisation to save those changes, so they remain unsaved."
  4. Price is unchanged in the shopfront

Animated Gif/Screenshot

Sorry the gif is so sloooooooow

inventory

Context

Severity

S2

Your Environment

  • Version used:
  • Browser name and version: Chrome
  • Operating System and version (desktop or mobile): Ubuntu Desktop
  • OFN Platform instance where you discovered the bug, and which version of the software they are using. V2 on FR staging

Possible Fix

@lin-d-hop lin-d-hop added the bug-s2 label Apr 9, 2019

@lin-d-hop

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2019

In fact this is all Inventory changes for this pair (TVFH and Berrio Mill). More gif:
inventory2

I'll do more testing with other ERs

@luisramos0 luisramos0 self-assigned this Apr 16, 2019

@luisramos0

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

the inventory page validates the full inventory on any change, so if there's one single variant broken, the page will be completely broken... it's unfortunate for the user but it's good to catch all bugs in the page...

this is a case of spoiled "Sponge Cake" :-) It's a deleted variant that is being shown in the inventory.

I'll create a PR...

@luisramos0

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

The deleted variant was not shown in the inventory but when the inventory data was being saved, the authorization procedure was checking this deleted variant and failed. Fixed in #3747

@sauloperez

This comment has been minimized.

Copy link
Contributor

commented Apr 19, 2019

Good work @luisramos0 !

@luisramos0 luisramos0 closed this May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.