Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[API clean up] Make OFN independent of spree_api #4054
What we should change and why (this is tech debt)
We need to drop spree_api dependency and bring what's needed to OFN.
There are 24 controllers in spree_api:
The rest are all not overriden in OFN:
From this list we can already see that, most probably, we need to bring the 7 working ones to OFN and probably none of the other ones are needed to keep OFN working as is without spree_api.
The major advantage is that we will have the OFN api in a single place and the extra advantage is that this will enable us to convert the views of these 7 api resources from rabl to ams and thus have the OFN API build with one single uniform tech stack.
At some point in the future we will need to adapt (or rebuild!) checkout and payments to OFN so that we offer the ability for external apps to checkout using the OFN API. For now, we can ignore this and just keep the functionality we have.
This comes as part of the OFN API clean up process started with it's documentation in #3001
Impact and timeline
This will need to be done before we clean up the api side of OFN, it will make things a lot easier because we are basically removing a lot of code in spree that we either dont use or is not working.