Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API clean up] Replace all rabl files with AMS serializers #4060

Open
luisramos0 opened this issue Jul 22, 2019 · 1 comment

Comments

@luisramos0
Copy link
Contributor

commented Jul 22, 2019

What we should change and why (this is tech debt)

AMS is the way to serialize objects in OFN. We have a few rabl files that need to be converted, time to finish up the clean up started 5 years ago.

Currently, this is the list of rabl files we have:

  • ./app/views/admin/json/_enterprises.rabl #4059
  • ./app/views/json/_order_cycle.rabl #4068
  • ./app/views/json/_flash.rabl #4059
  • ./app/views/json/_groups.rabl #4059
  • ./app/views/json/_taxon.rabl #4059
  • ./app/views/json/_hubs.rabl #4059
  • ./app/views/json/_current_user.rabl #4059
  • ./app/views/json/_current_order.rabl #4059
  • ./app/views/json/_enterprises.rabl #4059
  • ./app/views/json/_producers.rabl #4059
  • ./app/views/json/partials/_address.rabl #4059
  • ./app/views/json/partials/_enterprise.rabl #4059
  • ./app/views/json/partials/_hub.rabl #4059
  • ./app/views/json/partials/_producer.rabl #4059
  • ./app/views/json/_producer.rabl #4059
  • ./app/views/spree/admin/variants/search.rabl #4064
  • ./app/views/spree/api/variants/bulk_index.v1.rabl #4101
  • ./app/views/spree/api/variants/bulk_show.v1.rabl #4101
  • ./app/views/spree/api/products/bulk_index.v1.rabl #4101
  • ./app/views/spree/api/products/bulk_show.v1.rabl #4101
  • ./app/views/spree/api/users/authorise_api.v1.rabl #4111 (now in #4057)
  • ./app/views/api/product_images/update_product_image.v1.rabl #4073
  • ./app/views/api/enterprises/bulk_index.v1.rabl #4059
  • ./app/views/api/enterprises/bulk_show.v1.rabl #4101
  • ./app/views/api/order_cycles/bulk_index.v1.rabl #4059
  • ./app/views/api/order_cycles/bulk_show.v1.rabl #4059

Context

From removing spree_api where we will also need to convert rabl files (from spree_api views) to ams serializers).

Impact and timeline

We better do this now as part of the api clean up process.

@luisramos0

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2019

to close this we are only missing #4101 and #4111 (that is now in #4057)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.