Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Missing translation] Forgotten password email title not translated #6007

Closed
RachL opened this issue Sep 9, 2020 · 5 comments · Fixed by #6125
Closed

[Missing translation] Forgotten password email title not translated #6007

RachL opened this issue Sep 9, 2020 · 5 comments · Fixed by #6125
Assignees
Labels
bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround. good first issue hackathon Issues for upcoming hackathons

Comments

@RachL
Copy link
Contributor

RachL commented Sep 9, 2020

Description

When using the forgotten password feature, emails title are sent in English and cannot be translated currently. This issue is created to solve this problem.

Expected Behavior

The user should receive the email in the language they are suing on the platform

Actual Behaviour

Everyone receives the email in English

Steps to Reproduce

  1. From the home page, got to
  2. Fill your email in the forgotten password tab
  3. Check the email

Animated Gif/Screenshot

image

Severity

bug-s3: a feature is broken but there is a workaround

Your Environment

  • Version used: v3.2.6
  • Browser name and version: All browsers
  • Operating System and version (desktop or mobile): All devices

Possible Fix

I'm pasting here a comment from @luisramos0

I am not sure what is the method but probably we just need to implement this password_change method on our user_mailer. Should be an easy one.

@RachL RachL added good first issue bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround. labels Sep 9, 2020
@RachL
Copy link
Contributor Author

RachL commented Sep 9, 2020

@sauloperez would designing the email be a FE task? I mean the email is a bit ugly with lots of space between the text and no logo / footer like the others

@luisramos0
Copy link
Contributor

It's in rails, backend, haml.
btw, maybe we should redesign all the very-bad-looking emails at once? Is it just this one and the order shipped email, any other email without formatting?

@RachL RachL added the hackathon Issues for upcoming hackathons label Sep 25, 2020
@tsara27
Copy link
Contributor

tsara27 commented Oct 3, 2020

Hello @RachL

I am interested to be one of contributor for OFN.
I am sure I can help you with this fix. Could you please assign me this issue?

Thanks!

@luisramos0
Copy link
Contributor

👍 good luck with it @tsara27 let us know if you have any issues.

we are using devise 3.5.10
https://github.com/heartcombo/devise/tree/v3.5.10

I am not exactly sure what needs to be done here, you can explore.
My initial attempt would be to customize this password_change method:
https://github.com/heartcombo/devise/blob/v3.5.10/app/mailers/devise/mailer.rb
here:
https://github.com/openfoodfoundation/openfoodnetwork/blob/master/app/mailers/spree/user_mailer.rb

@tsara27
Copy link
Contributor

tsara27 commented Oct 3, 2020

good luck with it @tsara27 let us know if you have any issues.

we are using devise 3.5.10
https://github.com/heartcombo/devise/tree/v3.5.10

I am not exactly sure what needs to be done here, you can explore.
My initial attempt would be to customize this password_change method:
https://github.com/heartcombo/devise/blob/v3.5.10/app/mailers/devise/mailer.rb
here:
https://github.com/openfoodfoundation/openfoodnetwork/blob/master/app/mailers/spree/user_mailer.rb

Thank you for your advice. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround. good first issue hackathon Issues for upcoming hackathons
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants