Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Oeoeaio/uk/1031 insufficient stock in cart #1698
This is extension to PR #1583 as issue has appeared:
P.S. was not sure about naming on methods so please give better ones if you have any in mind.
What should we test?
Checkout process when incoming/outgoing products get unselected in admin order_cycles edit page.
How is this related to the Spree upgrade?
Hopefully it is not related unless later Spree versions has Orders implemented already with double check of this functionality.
How did validation look like? To me the validation does seem like the way to go rather than having to pollute the application controller. What about ensuring there are no orders still to be completed that have that variant in their line items when removing it from the order cycle? I'd then tell the admin through a flash error message.