Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enterprise description display formatting #2298

Conversation

@frank-west-iii
Copy link
Collaborator

commented May 18, 2018

What? Why?

Closes #953

There was an open issue left in the comments of issue #953, which this does not address due to some open questions. If that gets spun into a new issue this will close the issue.


Fix enterprise description display formatting

Removes text-small class from container and change container to div
instead of p for semantic differentiation.

Before:
before

After:
after

What should we test?

Update the "About Us" text for an enterprise to include different heading tags (h1, h2, etc) and observe that the formatting for the headings is now correct.

Release notes

Fixes enterprise about us heading formats so that they appear as expected

Fix enterprise description display formatting
Removes `text-small` class from container and change container to `div`
instead of `p` for semantic differentiation.
@daniellemoorhead

This comment has been minimized.

Copy link
Contributor

commented May 27, 2018

Hey @Matt-Yorkley or @mkllnk could one of you stage this for @myriamboure to test?

@myriamboure

This comment has been minimized.

Copy link
Contributor

commented May 28, 2018

Well done @frank-west-iii !
Testing notes: https://docs.google.com/document/d/1jvMGQbdP9DABccR4OD7QVSU2deR-4pI-DVOlL3ZAhmQ/edit#

Formatting is fixed, there is one remaining thing which is to force hyperink to open in new tab.
I opened a new issue for that @frank-west-iii if you want to work on it :-) #2339

Ready to go then :-)

@mkllnk mkllnk merged commit 307132d into openfoodfoundation:master May 29, 2018

3 checks passed

codeclimate 2 fixed issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.