Fixed producer profile translation bug #3644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisramos0
approved these changes
Mar 23, 2019
luisramos0
approved these changes
Mar 23, 2019
|
You got two positive reviews, excellent. One of our testers will now look at it on a staging server and tell you if it works as expected. That may take a few days. |
|
I don't see anything broken here, so this is good to go.
|
Closed
This was referenced Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Untranslated "producer profile" in pack selection page (front end)
Closes #[#3162]
Producer profile was hard coded as a string in English. I put the correct key-value pairs in the english file and then made t function call on them with respect to their status as primary producer.
What should we test?
Once transifex does it magic. It will be important to check if the correct key is called by the t function for non-english websites.
Release notes
String interpolation cannot be relied upon.
Fixed