Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing translation key for order shipment state canceled #3647

Conversation

luisramos0
Copy link
Contributor

What? Why?

Closes #3625

Add missing translation key.

What should we test?

Adding it to master so it can be translated but it will only be testable when merged to v2.
See issue for details of the test.

Release notes

Changelog Category: Added
Add missing translation key.

@luisramos0 luisramos0 self-assigned this Mar 24, 2019
@luisramos0 luisramos0 force-pushed the fix-shipment-state-translation branch from 52cc819 to 2c97eaa Compare March 24, 2019 15:33
Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, trusting you here.

@RachL
Copy link
Contributor

RachL commented Mar 27, 2019

@luisramos0 does this mean I can't actually test this one? Currently the cancelled state is well translated in master, so I guess it is linked to another key?

@luisramos0
Copy link
Contributor Author

yes, right, we need to merge this into 2-0 first.
I am merging this PR to master now (lets leave the issue open until this is merged to 2-0 and tested).

@luisramos0 luisramos0 merged commit 4455073 into openfoodfoundation:master Mar 27, 2019
@luisramos0 luisramos0 deleted the fix-shipment-state-translation branch March 27, 2019 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants