Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spree Upgrade] Fix split button reappearing when editing line item quantity #3689

Merged

Conversation

Projects
None yet
4 participants
@luisramos0
Copy link
Contributor

commented Apr 2, 2019

What? Why?

Closes #3683

#3683 is a bug in PR #3548 in this commit.
We need to remove the split button from the dom so that when spree does a toggle on it here, the button doesnt re-appear.

What should we test?

Make sure 3683 is fixed.

@luisramos0 luisramos0 self-assigned this Apr 2, 2019

@luisramos0 luisramos0 force-pushed the luisramos0:2-0-fix-split-button-bug branch from 2f7208f to ea52600 Apr 2, 2019

@mkllnk

mkllnk approved these changes Apr 13, 2019

@RachL RachL added the pr-staged-fr label Apr 16, 2019

@RachL RachL self-assigned this Apr 16, 2019

@RachL

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2019

Yes #3683 works!

image

I've tried it on fresh orders and past orders. And I understood how I've missed it previously : I must have forgotten to test with super admin access... and those buttons are only available for super admin. Sorry :(

@RachL RachL removed the pr-staged-fr label Apr 16, 2019

@luisramos0

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2019

awesome!

@luisramos0 luisramos0 merged commit eeac75a into openfoodfoundation:2-0-stable Apr 16, 2019

1 check passed

semaphoreci The build passed on Semaphore.
Details

@luisramos0 luisramos0 deleted the luisramos0:2-0-fix-split-button-bug branch Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.