Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spree Upgrade] Fix two issues in admin orders edit page #3701



None yet
4 participants
Copy link

commented Apr 5, 2019

What? Why?

Closes #3684 and #3685
Removes stock location from stock levels table and fix Spree.t entry bug.

This is the lazy man quick fix, this autocomplete.erb file needs to be converted to haml and the js code moved to angular. Next time... 馃檹

What should we test?

Order edit page works as usual, stock location column is not there and if variant is on demand, it shows the translation, not the Spree.t command.

@luisramos0 luisramos0 self-assigned this Apr 5, 2019

Copy link

left a comment

Maybe worth a quick view spec so when we do the non-lazy fix we are covered and confident? your call


This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2019

I want to skip it for now because it's not so easy. This template is loaded with spree js code. it would have to be a feature spec I think. I have added this to #3440


mkllnk approved these changes Apr 13, 2019

@RachL RachL self-assigned this Apr 17, 2019

@RachL RachL added the pr-staged-fr label Apr 17, 2019


This comment has been minimized.

Copy link

commented Apr 18, 2019

@RachL RachL removed the pr-staged-fr label Apr 18, 2019

@mkllnk mkllnk merged commit 736ac49 into openfoodfoundation:2-0-stable Apr 18, 2019

1 check passed

semaphoreci The build passed on Semaphore.

@luisramos0 luisramos0 deleted the luisramos0:2-0-fix-order-edit-issues branch Apr 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.