Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spree Upgrade] Update to spree revision that depends on aws-sdk 1.11.1 #3717

Merged

Conversation

Projects
None yet
4 participants
@luisramos0
Copy link
Contributor

commented Apr 9, 2019

What? Why?

This makes ofn gemfile.lock compatible with ofn/spree 2-0-4 gemspec. This problem was originally discussed here.

In this PR we update the spree revision to the revision generated in openfoodfoundation/spree#40

What should we test?

This build is green but only with #3641 and #3667

Manual Test: Product images are correctly uploaded to AWS.

Dependencies

This PR can only be merged after #3641.

@luisramos0 luisramos0 self-assigned this Apr 9, 2019

@luisramos0 luisramos0 force-pushed the luisramos0:2-0-update-aws-sdk branch from 0dcad12 to b8a5990 Apr 9, 2019

@luisramos0 luisramos0 added the pr-wip label Apr 9, 2019

@luisramos0 luisramos0 force-pushed the luisramos0:2-0-update-aws-sdk branch 2 times, most recently from c60fda3 to aa9d370 Apr 10, 2019

@luisramos0 luisramos0 removed the pr-wip label Apr 10, 2019

@luisramos0 luisramos0 force-pushed the luisramos0:2-0-update-aws-sdk branch from aa9d370 to fa58306 Apr 11, 2019

@luisramos0

This comment has been minimized.

Copy link
Contributor Author

commented Apr 11, 2019

rebased to see the green build.

@mkllnk

mkllnk approved these changes Apr 16, 2019

@luisramos0

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2019

I dont think we have the S3 connection in any staging server.
Maybe we can set it up for katuma, @sauloperez can you share access to aws?

@RachL RachL added the pr-staged-fr label Apr 16, 2019

@sauloperez

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2019

we don't store image uploads in S3 and we just created it to soon store backups there. Having at least a staging server use it it's a good point though.

@luisramos0

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2019

"we dont store images in s3" you mean Katuma right? other instances do that, correct?

@mkllnk

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

I can confirm that AU staging is using S3 for images.

@luisramos0

This comment has been minimized.

Copy link
Contributor Author

commented Apr 17, 2019

ok, thanks Maikel! Lets test it there then.

  1. Can I get access to that s3?
  2. the s3 config in staging au is empty in application.yml, maybe needs to be reconfigured?
@RachL

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

@luisramos0 if I understood correctly you will be testing this one on AU. I will then stage something else on fr

@RachL RachL removed the pr-staged-fr label Apr 17, 2019

@mkllnk

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

@luisramos0

Can I get access to that s3?

You find the API keys in the admin interface. They are stored in the database because the ofn-install feature to provision those keys hadn't worked for ages.

I'm not sure I can give you full access to the AWS account because there is a bit more connected to it. I will clarify that with Kirsten. Permission management is also a pain in AWS.

@luisramos0

This comment has been minimized.

Copy link
Contributor Author

commented Apr 17, 2019

hey, thanks Maikel.
I am off for a week now, maybe someone else can do that, so this PR is not stuck.

@RachL

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

@luisramos0 how do I know it is correctly uploaded by AWS? I just check if they are correctly uploaded?

@luisramos0

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2019

lets wait for #3771 to be merged so we get all the new s3 changes into this PR and then we can test this in katuma staging.

@luisramos0 luisramos0 added blocked and removed pr-staged-es labels May 2, 2019

@sauloperez

This comment has been minimized.

Copy link
Contributor

commented May 2, 2019

#3771 merged so we can test this.

@sauloperez sauloperez removed the blocked label May 2, 2019

@luisramos0 luisramos0 force-pushed the luisramos0:2-0-update-aws-sdk branch from fa58306 to a28b4a6 May 2, 2019

@luisramos0

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2019

I rebased this PR. We will test this on staging UK after testing release 1.31.0

as part of testing this PR, we should test #3771 which includes:

Update to spree revision that depends on aws-sdk 1.11.1 making ofn ge…
…mfile.lock compatile with ofn/spree 2-0-4 gemspec

@luisramos0 luisramos0 force-pushed the luisramos0:2-0-update-aws-sdk branch from e84ea19 to 5378862 May 3, 2019

@luisramos0 luisramos0 referenced this pull request May 3, 2019

Closed

Release v1.31.0 Bananas #3775

@RachL

This comment has been minimized.

Copy link
Contributor

commented May 3, 2019

I've tested #3697 #3607 and #3477 + uploading image is now working (and you can see on the image's URL that it is on an s3).

The rest are PR tested by automatic tests, so as everything is green we are ready to go!

https://docs.google.com/document/d/1L-EOraMS9YzeeIIH2yA1ioz8l8X5Seqny6dDocHmx8U/edit#

@RachL RachL removed the pr-staged-uk label May 3, 2019

@luisramos0

This comment has been minimized.

Copy link
Contributor Author

commented May 3, 2019

ahaha, so good!

@luisramos0 luisramos0 merged commit 4f0930b into openfoodfoundation:2-0-stable May 3, 2019

1 check passed

semaphoreci The build passed on Semaphore.
Details

@luisramos0 luisramos0 deleted the luisramos0:2-0-update-aws-sdk branch May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.