Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker configuration for quick local setup #3887

Conversation

@pacodelaluna
Copy link
Contributor

pacodelaluna commented May 30, 2019

What? Why?

Let's add a Docker setup for local environment. The idea behind it is to allow developers or testers to setup quickly there environment.

Closes #2290. Already closed by added for reference.

It will add great value to the project I think, people will be able to quickly see how the app is working and then focus their energy on real issues. On the downside, we will have to maintain this configuration but we have also to consider it as documentation, and almost real-time-updated one, so I think it worth it.

What should we test?

I have added a DOCKER.md file which describes the process to follow in order to have the application working locally. Tell me if it needs adjustments.

Release notes

  • Add Docker configuration for quick local setup

Changelog Category: Added

Documentation updates

I will add a link to the DOCKER.md file in the wiki once the PR is validated and merged.

@pacodelaluna pacodelaluna force-pushed the pacodelaluna:add-docker-configuration-for-dev-setup branch from ad61fa2 to 1b689ed May 30, 2019
Dockerfile Outdated
RUN apt-get update

## Rbenv & Ruby part

This comment has been minimized.

Copy link
@pacodelaluna

pacodelaluna May 30, 2019

Author Contributor

I could't use the ruby-2.1.5 Docker image as base because it is based on an old Ubuntu which is not maintained anymore. Rbenv will give us some flexibility for testing newer ruby version also.

This comment has been minimized.

Copy link
@sauloperez

sauloperez May 30, 2019

Contributor

I did a quick try the other day coming from the gathering and I think I did manage to get that image running. However, what you mention of being out-of-date is a valid point. However, I'd like to try starting from an Alpine Linux because it'll lead to a much more lightweight image.

This comment has been minimized.

Copy link
@pacodelaluna

pacodelaluna May 31, 2019

Author Contributor

Let's try with Alpine then, I was trying to use the images the closest to our prod, but lightness is a big concern too.

This comment has been minimized.

Copy link
@Matt-Yorkley

Matt-Yorkley Jun 14, 2019

Contributor

I have tried to use alpine but it is giving me issues with PhantomJS and also rbenv compilation.

I don't think it's worth spending more time getting Alpine to work. It's only for elite Docker-Hipsters anyway. 😉

@pacodelaluna

This comment has been minimized.

Copy link
Contributor Author

pacodelaluna commented May 30, 2019

@sauloperez @luisramos0 @Matt-Yorkley @mkllnk It is still not a 'oneliner' setup, but I think it can help devs for onboarding. It will possibly require some adjustments so don't hesitate to tell me.

@pacodelaluna pacodelaluna force-pushed the pacodelaluna:add-docker-configuration-for-dev-setup branch from 58f9da5 to 8f4e491 May 30, 2019
Copy link
Contributor

sauloperez left a comment

Awesome initiative @pacodelaluna ! It certainly time to get our heads around it IMO. I felt the urge now that I couldn't manage to install Ruby 2.1.5 because is too old for my new Ubuntu version. As time goes by this will happen more often with other dependencies 😱

I'll see if there's something I can share from my attempt.

DOCKER.md Outdated

Clone the repository:

git clone git@github.com:openfoodfoundation/openfoodnetwork.git

This comment has been minimized.

Copy link
@sauloperez

sauloperez May 30, 2019

Contributor

I'd rather use backticks (```) to make use of markdown's code blocks and precede commands with $ to make it more explicit. They are conventions I always follow in the wiki.

This comment has been minimized.

Copy link
@pacodelaluna

pacodelaluna May 31, 2019

Author Contributor

Ok, I will check this out, for now I just followed how GETTING_STARTED.md is written.

This comment has been minimized.

Copy link
@sauloperez

sauloperez May 31, 2019

Contributor

Good to know. Might be worth updating it. I strongly believe this makes it easier to read these long docs.


p '== Migrate'
Rake::Task['db:migrate'].invoke
end

This comment has been minimized.

Copy link
@sauloperez

sauloperez May 30, 2019

Contributor

I don't see the value of abstracting this. Can't we simply run bundle exec db:setup in docker-compose.yml? It does the db:create and db:seed for us. If we prefer, we could simply run bundle exec db:create db:schema:load instead.

Besides, there is no way around learning what each of these Rails tasks do is someone wants to develop, IMO. Hiding them does no good to new contributors.

This comment has been minimized.

Copy link
@pacodelaluna

pacodelaluna May 31, 2019

Author Contributor

The value is that we may not want to rebuild the dataset each time we are launching the container, especially that there are few tests that can take time to setup at data level, and you may need to restart the container for some reasons (Data migration, dependencies loading, ...). Also, it is not straight forward to load the data today and you unfortunately need to load them manually.

This task will provide some flexibility to the user who wants to perform some tasks launching the container, that's why I let some commented lines here too. It is not perfect, but it is a first step, I am always putting myself in the shoes of someone launching the app for the first time, and how to make it smoothly.

This was just to clarify my point of this weird task here, but if it is a real concern for you, I will adopt the strategy you propose, no problem.

This comment has been minimized.

Copy link
@sauloperez

sauloperez May 31, 2019

Contributor

let's see what others think. I would prefer teaching new devs to fish rather than giving ourselves the fish. Otherwise, I think we'll end up with lots of chat messages asking for help.

This comment has been minimized.

Copy link
@Matt-Yorkley

Matt-Yorkley Jun 14, 2019

Contributor

Yeah, I'd remove this. The rake tasks already exist, right? This logic can just go in the docker files. See my comment above for running db:seed non-interactively.

docker-compose.yml Outdated Show resolved Hide resolved
<<: *default
database: open_food_network_test
username: ofn
password: f00d

This comment has been minimized.

Copy link
@sauloperez

sauloperez May 30, 2019

Contributor

I'd rather work on openfoodfoundation/ofn-install#387 (which I really want to do soon) which will provide the needed flexibility with ENV vars so we don't need to add purpose-specific database.yml like this one.

This comment has been minimized.

Copy link
@pacodelaluna

pacodelaluna May 31, 2019

Author Contributor

Ok, let's wait for it then.

This comment has been minimized.

Copy link
@Matt-Yorkley

Matt-Yorkley Jun 14, 2019

Contributor

openfoodfoundation/ofn-install#387 would be nice, but I don't think it needs to block this Docker setup..?

This comment has been minimized.

Copy link
@sauloperez

sauloperez Jun 18, 2019

Contributor

We can go with #3954

Dockerfile Outdated
RUN apt-get update

## Rbenv & Ruby part

This comment has been minimized.

Copy link
@sauloperez

sauloperez May 30, 2019

Contributor

I did a quick try the other day coming from the gathering and I think I did manage to get that image running. However, what you mention of being out-of-date is a valid point. However, I'd like to try starting from an Alpine Linux because it'll lead to a much more lightweight image.

Dockerfile Outdated
RUN curl -sL https://deb.nodesource.com/setup_8.x | bash - && \
curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | apt-key add - && \
echo "deb https://dl.yarnpkg.com/debian/ stable main" | tee /etc/apt/sources.list.d/yarn.list
RUN apt-get update && apt-get install -y nodejs yarn

This comment has been minimized.

Copy link
@sauloperez

sauloperez May 30, 2019

Contributor

I'd great to run them with a single RUN command to creating multiple intermediate images and the disk space that takes.

This comment has been minimized.

Copy link
@pacodelaluna

pacodelaluna Jun 6, 2019

Author Contributor

I couldn't see these intermediate images while building the app, but I could see that RUN is helping stepping the image construction. I gave still reduce the number of calls to 3.

Dockerfile Outdated
RUN apt-get install -yqq --no-install-recommends build-essential git-core curl zlib1g-dev libssl-dev libreadline-dev libyaml-dev libxml2-dev libxslt1-dev libcurl4-openssl-dev libffi-dev phantomjs

# System dependencies
RUN apt-get install -y wait-for-it

This comment has been minimized.

Copy link
@sauloperez

sauloperez May 30, 2019

Contributor

See my comment about RUN above. I believe each of these commands creates a separate image that Docker caches.

DOCKER.md Outdated
@@ -0,0 +1,66 @@
### Docker

It is possible to setup the OpenFoodnetwork app easily with Docker and Docker Compose.

This comment has been minimized.

Copy link
@sauloperez

sauloperez May 30, 2019

Contributor

OpenFoodnetwork => OpenFoodNetwork or Open Food Network


Please check the documentation here, https://docs.docker.com/install/ to install Docker.

For Docker Compose, information are here: https://docs.docker.com/compose/install/.

This comment has been minimized.

Copy link
@sauloperez

sauloperez May 30, 2019

Contributor

information is here 👌

@pacodelaluna pacodelaluna force-pushed the pacodelaluna:add-docker-configuration-for-dev-setup branch 2 times, most recently from 7a1e368 to cb1101f Jun 6, 2019
@pacodelaluna

This comment has been minimized.

Copy link
Contributor Author

pacodelaluna commented Jun 6, 2019

I have fixed many remarks, but there are still 3 points to consider:

  1. Use of alpine base instead ubuntu one: I have tried to use alpine but it is giving me issues with PhantomJS and also rbenv compilation. I don't want to spend more time on it as it will just save some MBs on hard drive, I feel like spending this time coding but if someone want to take a look with me, we can do it together.

  2. Avoid specific rake task for setup: I can't figure out a fast setup without this task as imho docker-compose should run the migrations, and migrations are not running properly from a fresh db. It is not ideal but it is working. And this setup is not only for devs, it should help anybody to setup the env locally.

  3. Remove the Docker-specific database.yml file: This task is linked to an other one, so we can wait for it, or update the Docker configuration once the other task is done (openfoodfoundation/ofn-install#387), it depends how long it will take.

@sauloperez Please tell your opinion about these points.

Copy link
Member

mkllnk left a comment

Great work! And it doesn't have to be perfect. I totally understand that you don't want to invest much more time. There is just one thing I'm wondering: Do all these files need to be in the openfoodnetwork repository? The only dependency I see here is COPY . /usr/src/app/, is that right? Could we copy from somewhere else or clone it from Github?
I'm just asking because a big problem of our code base is that it's too big and we would like to make it more modular.

DOCKER.md Outdated

### Notes

- It was not possible to integrate the seeding part directly because we need the input of the user and Docker Compose was not allowing it. Need to fix this.

This comment has been minimized.

Copy link
@mkllnk

mkllnk Jun 13, 2019

Member

Can you set environment variables? Setting AUTO_ACCEPT should skip the username and password question.

This comment has been minimized.

Copy link
@Matt-Yorkley

Matt-Yorkley Jun 14, 2019

Contributor

💯 for ENV['AUTO_ACCEPT'] = true

Then we can run the db:seed task without any prompts, and the default login details will be: spree@example.com and spree123. Alternatively you can set custom values using ENV['ADMIN_EMAIL'] and ENV['ADMIN_EMAIL'].

So that actually means both the db:seed and ofn:sample_data tasks can be run automatically during the setup, and there's no need for extra manual steps from the user. 🚀🚀🚀

This comment has been minimized.

Copy link
@Matt-Yorkley

Matt-Yorkley Jun 14, 2019

Contributor

It is still not a 'oneliner' setup

We can do it! 💪 😄

This comment has been minimized.

Copy link
@pacodelaluna

pacodelaluna Jun 18, 2019

Author Contributor

@Matt-Yorkley Thanks for the trick! I will try it asap.

@mkllnk I agree that we could put this outside this repository, just saw the Vagrant image made by @Matt-Yorkley few days ago, we could do something similar.

This comment has been minimized.

Copy link
@luisramos0

luisramos0 Jun 19, 2019

Contributor

is the seeding part integrated now? we need to remove this line if that is the case.

Dockerfile Outdated
ENV BUNDLE_PATH /bundles

COPY . /usr/src/app/
COPY Gemfile* /usr/src/app/

This comment has been minimized.

Copy link
@mkllnk

mkllnk Jun 13, 2019

Member

Why do we need to copy the Gemfile separately?

This comment has been minimized.

Copy link
@pacodelaluna

pacodelaluna Jun 18, 2019

Author Contributor

Good question :) I will check this out.

@@ -0,0 +1,64 @@
# Add application configuration variables here, as shown below.

This comment has been minimized.

Copy link
@mkllnk

mkllnk Jun 13, 2019

Member

Why not use the example file?

This comment has been minimized.

Copy link
@pacodelaluna

pacodelaluna Jun 18, 2019

Author Contributor

Good idea! It will reduce docker footprint.

This comment has been minimized.

Copy link
@Matt-Yorkley

Matt-Yorkley Jun 19, 2019

Contributor

Are there any variables that need to be customised?

Dockerfile Outdated
gem install bundler --version=1.17.2

# Postgres
RUN sh -c "echo 'deb http://apt.postgresql.org/pub/repos/apt/ precise-pgdg main' > /etc/apt/sources.list.d/pgdg.list" && \

This comment has been minimized.

Copy link
@Matt-Yorkley

Matt-Yorkley Jun 14, 2019

Contributor

Shouldn't this be bionic-pgdg main instead of precise-pgdg main if you're using the ubuntu:18.04 image?

Copy link
Contributor

Matt-Yorkley left a comment

Nice work @pacodelaluna! I left a couple of comments. 👍

@sauloperez

This comment has been minimized.

Copy link
Contributor

sauloperez commented Jun 14, 2019

I still want to give a try and share feedback. I might switch from my current lxc setup.

I'm ok about 1. but I'd like to tackle 2. and 3. Agree though that we could address them separately.

Dockerfile Outdated
FROM ubuntu:18.04

#Install all the requirements
RUN apt-get update && apt-get install -y curl git build-essential software-properties-common wget zlib1g-dev libssl1.0-dev libreadline-dev libyaml-dev libffi-dev libxml2-dev libxslt1-dev phantomjs wait-for-it

This comment has been minimized.

Copy link
@Matt-Yorkley

Matt-Yorkley Jun 14, 2019

Contributor

I think we don't use phantomjs anymore.

This comment has been minimized.

Copy link
@pacodelaluna

pacodelaluna Jun 18, 2019

Author Contributor

I will try to remove it then, was getting it from the wiki.

@Matt-Yorkley

This comment has been minimized.

Copy link
Contributor

Matt-Yorkley commented Jun 14, 2019

I just had a play with this, it's pretty awesome. I made some tweaks here, the command is still a bit hacky though: pacodelaluna/openfoodnetwork@add-docker-configuration-for-dev-setup...Matt-Yorkley:vamos

No manual setup steps 💪

So does this mean we can create a downloadable Docker image from this, and devs won't have to build Ruby with rbenv again? 😄

@sauloperez

This comment has been minimized.

Copy link
Contributor

sauloperez commented Jun 18, 2019

So does this mean we can create a downloadable Docker image from this, and devs won't have to build Ruby with rbenv again?

❤️

@sauloperez

This comment has been minimized.

Copy link
Contributor

sauloperez commented Jun 18, 2019

LOL the branch name @Matt-Yorkley 🤣 I prefer your suggestion 👍

adapter: postgresql
encoding: utf8
pool: 5
timeout: 5000

This comment has been minimized.

Copy link
@sauloperez

sauloperez Jun 18, 2019

Contributor

why do we need that?

pool: 5
timeout: 5000
host: db
port: 5432

This comment has been minimized.

Copy link
@sauloperez

sauloperez Jun 18, 2019

Contributor

we surely don't need that

sauloperez added a commit that referenced this pull request Jun 18, 2019
This enables us to fix
openfoodfoundation/ofn-install#387 and brings the
needed flexibility so things like
#3887 or any CI don't
require a custom version. That's what ENV vars are for!

For instance, I no longer need to mess with my LXC setup to connect to the DB.
I just need to have 2 env vars.
@pacodelaluna

This comment has been minimized.

Copy link
Contributor Author

pacodelaluna commented Jun 18, 2019

@Matt-Yorkley Great, you fixed almost all the comments. I add you on my repository as collaborator, or you can create a new PR. Let's work on the same branch to avoid merge issues. I will work on the @mkllnk remarks about the use of example files in Docker Compose.
I think that with this, it will just be 3 Docker files and 1 MD file, which is a pretty reduce footprint, don't know if we should still put it outside the repository. @Matt-Yorkley @sauloperez @luisramos0 What do you think about it?

@luisramos0

This comment has been minimized.

Copy link
Contributor

luisramos0 commented Jun 18, 2019

we will fine with this in ofn repo or outside, I'd vote to keep it inside the repo if only a couple of new files.
Docker is quite fancy, and not just that, it's a good sign we use docker and I think that keeping it in ofn repo makes it more visible and will probably make more people use it and improve it.

@mkllnk

This comment has been minimized.

Copy link
Member

mkllnk commented Jun 19, 2019

It can stay in the repository if it's only a couple of files. Or we create a docker folder for the files in the repository. I'm just aware that we have many files for many different tools and it can get a bit messy.

# current master
$ ls -a
app
bin
.bundle
.codeclimate.yml
config
config.ru
CONTRIBUTING.md
coverage
db
engines
Gemfile
Gemfile.lock
GETTING_STARTED.md
.git
.github
.gitignore
Guardfile
knapsack_rspec_report.json
lib
LICENCE.txt
log
.mailmap
nbproject
node_modules
.node-version
package.json
public
Rakefile
README.md
reports
.rspec
.rubocop_manual_todo.yml
.rubocop_styleguide.yml
.rubocop_todo.yml
.rubocop.yml
.ruby-gemset
.ruby-version
script
.scss-lint.yml
spec
tmp
.travis.yml
.tx
vendor
zeus.json
@amazzoccone

This comment has been minimized.

Copy link

amazzoccone commented Jun 19, 2019

+1 @pacodelaluna ! 🎉 There are multiple advantages from implement Docker, both in local and production envs.

  • Local: quick setup and standard env (everyone has a more similar environment, except for os of course) are the first ones, helping new contributors as well and no need to force developer to install the stack (db, cache, language, etc). Few have the complete stack: Rails, Ruby and PostgreSQL database and less the exact version.
  • Stage/Production: useful in the integration (preparation of the deployment of a new release), simplifying a lot of the process with the usage of images and a registry, etc etc.

In my opinion, at least at the beginning would be great to have the choice of Docker in local env.

@luisramos0

This comment has been minimized.

Copy link
Contributor

luisramos0 commented Jun 19, 2019

welcome to OFN @amazzoccone
join us on slack 🎸 https://openfoodnetwork.org/slack-invite

@Matt-Yorkley

This comment has been minimized.

Copy link
Contributor

Matt-Yorkley commented Jun 19, 2019

@pacodelaluna I submitted my suggestions as a PR on your branch 👍

Copy link
Contributor

Matt-Yorkley left a comment

Awesome. I vote for keeping it in the repo. We can start using it and iterate later if we find some other improvements to make.

Copy link
Contributor

luisramos0 left a comment

I left some rubocop type of comments.

Looks like the only question we need to answer before merging this is: do we really need these files?
config/database.docker.yml
config/application.docker.yml

DOCKER.md Outdated

It is possible to setup the Open Food Network app easily with Docker and Docker Compose.
The objective is to spare configuration time, in order to help people testing the app and contribute to it.
It can also be use as documentation. It is not perfect but it is used in many other projects and many devs are used to it nowadays.

This comment has been minimized.

Copy link
@luisramos0

luisramos0 Jun 19, 2019

Contributor

typo: It can also be useD as documentation.

DOCKER.md Outdated

For Docker Compose, information are here: https://docs.docker.com/compose/install/.

Better to have at least 2GB free on your laptop in order to download images and create containers for Open Food Network app.

This comment has been minimized.

Copy link
@luisramos0

luisramos0 Jun 19, 2019

Contributor

on your computer

DOCKER.md Outdated
$ bundle exec rake db:seed
```

Load thre sample data from Open Food Network:

This comment has been minimized.

Copy link
@luisramos0

luisramos0 Jun 19, 2019

Contributor

Load THE sample

DOCKER.md Outdated

### Notes

- It was not possible to integrate the seeding part directly because we need the input of the user and Docker Compose was not allowing it. Need to fix this.

This comment has been minimized.

Copy link
@luisramos0

luisramos0 Jun 19, 2019

Contributor

is the seeding part integrated now? we need to remove this line if that is the case.

Dockerfile Outdated
@@ -0,0 +1,32 @@
FROM ubuntu:18.04

#Install all the requirements

This comment has been minimized.

Copy link
@luisramos0

luisramos0 Jun 19, 2019

Contributor

space after #

Dockerfile Outdated
#Install all the requirements
RUN apt-get update && apt-get install -y curl git build-essential software-properties-common wget zlib1g-dev libssl1.0-dev libreadline-dev libyaml-dev libffi-dev libxml2-dev libxslt1-dev wait-for-it

#Setup ENV variables

This comment has been minimized.

Copy link
@luisramos0

luisramos0 Jun 19, 2019

Contributor

space after #

you can probably run rubocop on this file as well to get these things flagged.

@pacodelaluna pacodelaluna force-pushed the pacodelaluna:add-docker-configuration-for-dev-setup branch from bec0ba9 to e68d72c Jun 25, 2019
@pacodelaluna

This comment has been minimized.

Copy link
Contributor Author

pacodelaluna commented Jun 25, 2019

I have rebased and fixed all the comments, but I had a last issue with the Sample Data setup. It was failing while relaunching the container, some constraints on Customer object on db:setup. I have decided to reset the db instead but then we are having an issue with ofn:sample_data, Spree::User object is not found inside the environment (possibly because db:reset is flushing it).
I fixed this with the next commit, but please tell me if there is an issue. Not sure it is so good to reset data all the time, but we can tweak this easily.
Anyway, I guess we will have to work on Sample Data soon or later, but it will be an other topic.

Copy link
Member

mkllnk left a comment

Just another two comments. They are tiny changes.

Dockerfile Outdated

# Postgres
RUN sh -c "echo 'deb http://apt.postgresql.org/pub/repos/apt/ bionic-pgdg main' > /etc/apt/sources.list.d/pgdg.list" && \
wget --quiet -O - http://apt.postgresql.org/pub/repos/apt/ACCC4CF8.asc | apt-key add - && \

This comment has been minimized.

Copy link
@mkllnk

mkllnk Jun 25, 2019

Member

I would definitely use the https URL to obtain a key. Otherwise the whole cryptography with signatures is useless.

This comment has been minimized.

Copy link
@pacodelaluna

pacodelaluna Jun 25, 2019

Author Contributor

Totally right, just updated it.

@@ -0,0 +1,64 @@
# Add application configuration variables here, as shown below.

This comment has been minimized.

Copy link
@mkllnk

mkllnk Jun 25, 2019

Member

This is exactly the same file as config/application.yml.example. Can't we use the existing file? Or rename it to this one if we need to? That would just need some other changes in other places.

This comment has been minimized.

Copy link
@pacodelaluna

pacodelaluna Jun 25, 2019

Author Contributor

Right, forgot to delete the old one, just updated it.

@luisramos0

This comment has been minimized.

Copy link
Contributor

luisramos0 commented Jun 25, 2019

are you renaming the sample file on purpose or is it just a mistake?
config/application.yml.example → config/application.example.yml

if you want/need to rename it, you will need to update a few more things, see the broken build.

@pacodelaluna

This comment has been minimized.

Copy link
Contributor Author

pacodelaluna commented Jun 25, 2019

@luisramos0 Yes, I am renaming it as it will be clearer for syntax detection, what to you think about it? Just fixed the setup script, I guess it was the spec issue.

@luisramos0

This comment has been minimized.

Copy link
Contributor

luisramos0 commented Jun 25, 2019

I see why you want to rename the file but you may be creating trouble with this.
you need to change the semaphore build config here: https://semaphoreci.com/openfoodfoundation/openfoodnetwork-2/settings
and also you need to update ofn-install/scripts/db-setup.sh as well

maybe easier to leave it as it was?

@pacodelaluna

This comment has been minimized.

Copy link
Contributor Author

pacodelaluna commented Jun 25, 2019

Sure, touched a Pandora box here :) I put back as it was.

@luisramos0

This comment has been minimized.

Copy link
Contributor

luisramos0 commented Jun 25, 2019

sorry, still not correct, you are deleting config/application.yml.example now

@pacodelaluna

This comment has been minimized.

Copy link
Contributor Author

pacodelaluna commented Jun 25, 2019

@luisramos0 Sorry, forgot to add the file, fixed now. I think we are good now. 6 files modified, looks good.

Copy link
Contributor

luisramos0 left a comment

yes, looks good now 👍

- .:/usr/src/app
- gems:/bundles
- ./config/database.yml:/usr/src/app/config/database.yml
- ./config/application.example.yml:/usr/src/app/config/application.yml

This comment has been minimized.

Copy link
@mkllnk

mkllnk Jun 25, 2019

Member

Don't you need to change this line now to use the old file application.yml.example?

This comment has been minimized.

Copy link
@pacodelaluna

pacodelaluna Jun 26, 2019

Author Contributor

Good catch, I have rebuild the image, the container is running, hope it is good now...

@mkllnk
mkllnk approved these changes Jun 26, 2019
@mkllnk mkllnk merged commit eebc49f into openfoodfoundation:master Jun 26, 2019
2 checks passed
2 checks passed
codeclimate 1 fixed issue
Details
semaphoreci The build passed on Semaphore.
Details
@luisramos0

This comment has been minimized.

Copy link
Contributor

luisramos0 commented Jun 26, 2019

@pacodelaluna 👏 👏 👏

Matt-Yorkley added a commit that referenced this pull request Jul 2, 2019
This enables us to fix
openfoodfoundation/ofn-install#387 and brings the
needed flexibility so things like
#3887 or any CI don't
require a custom version. That's what ENV vars are for!

For instance, I no longer need to mess with my LXC setup to connect to the DB.
I just need to have 2 env vars.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.