Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Make weight calculator use line_item.final_weight_volume rather than variant.weight #3895
This is for cases where the final weight is set manually in the BOM
Re 3661, the fees are being recalculated, the problem is that the manual weight was not being picked up.
What should we test?
We need to verify all cases where the weight calculator is used.
Changelog Category: Fixed
May 31, 2019
kristinalim left a comment
@luisramos0 I was wondering about the
In consideration of above, this is another possible gotcha:
ah, nice one Kristina, I didnt see that part of this puzzle
When the product is set for "items" the final_weight_volume is set from the unit_value as well which is the number of items in a variant...
I think it's better to leave this logic above as is with unit_value (volume or items) populating final_weight_volume...
So, I think the current code in this PR is ok as is. Do you see a better alternative?