Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back ‘Shop for X products at:’ title #3943

Merged
merged 1 commit into from Jun 21, 2019

Conversation

Projects
None yet
5 participants
@jonleighton
Copy link
Contributor

commented Jun 17, 2019

What? Why?

Fixes #2112

It looks like this bug was accidentally introduced during a refactor in
e5ca494. The bo-html attribute was
replaced with ng-html, but it appears that it should actually have
used ng-bind-html
(https://docs.angularjs.org/api/ng/directive/ngBindHtml) because the
former is not a valid AngularJS directive.

It was also necessary to bubble up the .cta-container class in order to
get the appropriate styling on the title.

Before

image

After

image

What should we test?

The producer modal

Release notes

Bring back the 'Shop for X products at:' title on the producer modal. This was
accidentally lost some time ago.

Changelog Category: Fixed

Bring back ‘Shop for X products at:’ title
Fixes #2112

It looks like this bug was accidentally introduced during a refactor in
e5ca494. The `bo-html` attribute was
replaced with `ng-html`, but it appears that it should actually have
used `ng-bind-html`
(https://docs.angularjs.org/api/ng/directive/ngBindHtml) because the
former is not a valid AngularJS directive.

It was also necessary to bubble up the `.cta-container` class in order to
get the appropriate styling on the title.

@jonleighton jonleighton force-pushed the jonleighton:issue-2112 branch from d31a676 to fcff302 Jun 17, 2019

@luisramos0
Copy link
Contributor

left a comment

Thanks Jon!
It's great to have you here 🎉

@sauloperez
Copy link
Contributor

left a comment

Nice one!

@RachL RachL added the pr-staged-es label Jun 20, 2019

@RachL RachL self-assigned this Jun 20, 2019

@RachL

This comment has been minimized.

Copy link
Contributor

commented Jun 20, 2019

This is looking on staging! Thanks and welcome @jonleighton :)

image

@RachL RachL removed the pr-staged-es label Jun 20, 2019

@mkllnk mkllnk merged commit e4c3c16 into openfoodfoundation:master Jun 21, 2019

2 checks passed

codeclimate All good!
Details
semaphoreci The build passed on Semaphore.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.