Fix Permissions::Order spec in rails 4 #5151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ave to set the producer of the products in the order This is working in master by chance of the factories but breaks in rails 4 because the orders in this test dont have products supplied by the producer which is a necessary condition in the context where it was
luisramos0
changed the title
sauloperez
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Fixes permissions::order service spec in the rails 4 branch.
The problem was introduced here by relying on order (from factories) that have products by the same producer required in the test:
https://github.com/openfoodfoundation/openfoodnetwork/pull/5030/files#diff-610e1eeeabb29a85e6d4a271d2bd7f56R75
In rails 4 the products in these orders dont have the same producer as required and so the test breaks.
We move the test to a simpler context above. It's still valid and it just validates what it is meant to validate.
See commit messages for more details.
What should we test?
green build
Release notes
Changelog Category: Changed
Adapted test code to rails 4 related to order permissions.