Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace create with build_stubbed in shipping rate model specs #6074

Merged
merged 1 commit into from Sep 24, 2020
Merged

Replace create with build_stubbed in shipping rate model specs #6074

merged 1 commit into from Sep 24, 2020

Conversation

arku
Copy link
Contributor

@arku arku commented Sep 22, 2020

What? Why?

Related to #6062

Replaces FactoryBot::Syntax::Methods#create calls with FactoryBot::Syntax::Methods#build_stubbed in the Spree::ShippingRate model specs to improve the test suite performance.

What should we test?

Release notes

Improve specs' performance.

Changelog Category: Added | Changed | Deprecated | Removed | Fixed | Security

Discourse thread

Dependencies

Documentation updates

@luisramos0 luisramos0 merged commit 8919adb into openfoodfoundation:master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants