Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

ofQuaternion::makeRotate takes degrees, used to take radians, documentation says radians #646

Closed
andreasmuller opened this Issue · 2 comments

4 participants

Andreas Müller arturo Jonathan Dahan Kyle McDonald
Andreas Müller

A tiny issue I spotted:

ofQuaternion.cpp, line 14:

/// Set the elements of the Quat to represent a rotation of angle
/// (radians) around the axis (x,y,z)
void ofQuaternion::makeRotate( float angle, float x, float y, float z ) {
    angle = ofDegToRad(angle);

ofXQuaternion::makeRotate used to take radians, only noticed as I was moving some old code over, otherwise I would have just looked at the code in ofQuaternion.cpp to see the angle type.

arturo
Owner

memo changed this and some other methods to work with radians to make it consistent with everything else, have changed the comment, won't close the issue so we remember to update the docs

Jonathan Dahan

Looks like this can be closed, as this was done correctly in a5afb33 I think.
http://www.openframeworks.cc/documentation/math/ofQuaternion.html#!show_makeRotate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.