Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

videoinput lib global statics #697

Closed
danomatika opened this Issue · 10 comments

4 participants

@danomatika

I'm trying to build ofxPd in Visual Studio and running into multiple define issues related to the videoinput lib, namely static verbose: https://github.com/openframeworks/openFrameworks/blob/master/libs/videoInput/include/videoInput.h#L115

Couldn't this variable as well as comInitCount be moved to the implementation files? or at least in a header hidden from the global namespace? At the least, verbose could be renamed to something not so common ...

@danomatika

No change on this?

@danomatika

This is still an issue for ofxPd users on Windows ...

@bilderbuchi
Owner

at least verbose looks like it should be factored out and replaced by ofLog calls, anyway.

@bilderbuchi
Owner

@danomatika you wanna tackle this for 0073?
@ofTheo just making sure this code is still relevant? last changes to videoInput.h were in 2009...

@bakercp
Collaborator

@ofTheo and while you're in there @danomatika (if you tackle this) this might be a good time add a concentrated effort to redefine listDevices() from the base class on up so that it actually returning something actionable, rather than printing a device list to the console. I'm happy to help on the OSX and Gstreamer end. I got hung up on the videoInput.h side of things b/c of my linux/osx tendencies.

See related discussions, some research I did and a TODO listing off where the changes need to be made across the board:

#645 #91 #461

@bilderbuchi
Owner

Wouldn't it be better to put this in a separate, new issue, Christopher?

@bakercp
Collaborator

Yes it should be a different issue, but I didn't open an issue on it, b/c there are already two duplicated on the same topic (one opened by @danomatika #461 and one by @arturoc #91). Just trying to provoke some discussion with the above post. Perhaps you could merge the two for a concentrated discussion there?

@bilderbuchi
Owner

I see. I just closed 461, best to continue the discussion in #91.

@ofTheo
Owner

yeah - def mark for 0073
I can update videoInput and fix this issue and also add device listing to string vector.

@ofTheo ofTheo was assigned
@ofTheo
Owner

Okay this is now fixed in https://github.com/ofTheo/videoInput/commits/update2013
I will be merging this branch to develop soon and then build new libs for 0.8.0 release.

@ofTheo ofTheo closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.