Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default values to private members of ofGLRenderer. #1812

Merged
merged 3 commits into from Mar 3, 2013
Merged

add default values to private members of ofGLRenderer. #1812

merged 3 commits into from Mar 3, 2013

Conversation

thiagohersan
Copy link
Contributor

closes #1787.

I also changed the name of a private variable (bFilled -> fillFlag). If that's not cool, I can change it back.

@kylemcdonald
Copy link
Contributor

generally looks correct, but i think that (200,200,200) is defined somewhere else in the core as well. would be good to either copy it, remove the other case, or something to minimize duplication of that value.

@thiagohersan
Copy link
Contributor Author

you're right. this does set it at the renderer level as well.

I'm removing that line.

@kylemcdonald
Copy link
Contributor

cool, that's a reasonable solution. looks good!

@bakercp
Copy link
Member

bakercp commented Jan 13, 2013

+1.

arturoc added a commit that referenced this pull request Mar 3, 2013
add default values to private members of ofGLRenderer.
@arturoc arturoc merged commit 5764ce1 into openframeworks:develop Mar 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants