Skip to content

ofQTKitPlayer audio monitoring functions #1979

Closed
wants to merge 7 commits into from

3 participants

@prisonerjohn

Added some functions for monitoring Quicktime movie audio frequency and volume levels.

You can configure the number of channels and bands, and you can set whether you want to monitor frequency or volume.

I also added an example that shows all this in action.

@obviousjim This is the same functionality that you looked at a couple of days ago, just a little more oF-y.

@kylemcdonald

@obviousjim what do you think about this?

@obviousjim

Thanks for the nudge. pulling into a local branch and taking a look,

@obviousjim

I looked through code and it seems really awesome, and definitely useful. Here are my concerns:

1) The QTKit based video player is straying further from the cross-platform supported features in OF. This is a general OF strategy, something that @arturoc could comment on. Is this a problem or is it ok?

2) Moving forward, I think we see QTKit as a bandaid solution for a GStreamer or AVFoundation implementation. Are we stitching ourselves up by adding this to the core in that we must 'promise' to support audio frequency with the similar API as we move forward to new solutions. Or can we leave it as a 'one off bonus' for those who choose to use ofQTKitPlayer directly?

From a code perspective, it looks clean and worked well for me. Be good to get a few more eyes on it, @bakercp always has a discretionary opinions

@prisonerjohn

Bump @arturoc @bakercp @obviousjim

I guess this could also be an addon if that makes more sense.

@obviousjim

Is there a way to structure it as an addon that just uses the ofQTKitPlayer object internally? I'd be worried about having another QTKit movie player with duplciated code floating around

@prisonerjohn

My first instinct would be to subclass ofQTKitPlayer and ofQTKitMovieRenderer and override ofQTKitPlayer::loadMovie() and `ofQTKitPlayer::update().

But that would require modifications to the current classes. I would need access to some private variables like ofQTKitPlayer.moviePlayer and [ofQTKitMovieRendere .movie].

@prisonerjohn prisonerjohn deleted the prisonerjohn:feature-qtkit-audio branch Oct 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.