add rules and parsing for .mm and .m in makefiles #1993

Closed
wants to merge 1 commit into
from

Projects

None yet

4 participants

@thiagohersan
Contributor

makefile was missing rules for dealing with .mm and .m files in addons and projects.

this was tested on a project that uses ofxFenster in osx.

@arturoc @bakercp, do you see any issues with this? do .mm and .m file extensions show up in other contexts that might cause problems?

word.

@bakercp
Member
bakercp commented Apr 3, 2013

Hey @thiagohersan I've got a branch in progress that fixes this over here: bakercp@a034320

(I just pushed the commits for reference). It isn't quite finished yet, but solves a bunch of problems, particularly with OSX Makefile systems, gets rid of the need for the export directory etc.

If you search that commit, you can see where I injected m/mm. Basically getting ofxSyphon to work with the OSX makefile system was the worst case scenario and it's working now (I haven't pushed all necessary changes yet). I believe my changes are very similar to yours.

I haven't touched base w/ @arturoc lately on the makefile scene, but we should definitely get coordinated :) @arturoc your thoughts?

@thiagohersan
Contributor

nice !!
yeah... your changes are more comprehensive. I'll close this PR when you make yours : )

@bakercp
Member
bakercp commented Apr 3, 2013

Fair enough :)

@arturoc
Member
arturoc commented Apr 3, 2013

@bakercp looks good, perhaps send a PR even if it's not finished so we can review it as you do changes

@bilderbuchi
Member

I just noticed an interesting variable name typo: $(OF_PROJECT_OBJ_OUPUT_PATH) - OU T PUT - is that in too many makefiles now to fix it, or did you guys just not see it until now? :-)

@bakercp
Member
bakercp commented Jun 14, 2013

This is included here #2092 so I'm closing this, per our discussion above!

Thanks!!

@bakercp bakercp closed this Jun 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment