Poco libs fix for Windows VS2012 using 1.4.3p #2771 #2776

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

chuckleplant commented Jan 24, 2014

Built version 1.4.3p with VS2012 support, could it be that we need to update headers instead? This is a quick fix for retro compatibility

Owner

bilderbuchi commented Jan 24, 2014

could you please resubmit with just one commit, otherwise this will have unnecessary binary overhead from the immediate rebuild (i.e. you add the size of the binaries to the git repo twice)

Contributor

chuckleplant commented Jan 24, 2014

how do I choose the commit for PRs?

Owner

bilderbuchi commented Jan 24, 2014

In this case, it is probably easiest to create a new PR branch from OF master, and then cherry pick 54a6f68 onto this branch, then make a new PR.

Owner

bilderbuchi commented Jan 24, 2014

Also, since you did not create a separate PR branch for this PR, as the Contributing document recommends, prepare for some work when you update your local master from OF/master the next time, because the two commits in this PR will not make their way into OF/master.... resettting your local branch back a few commits with git reset --hard HEAD~<number> should sort you out by deleting the commits in question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment