Update ofxAssimpModelLoader.cpp #2830

Merged
merged 1 commit into from Mar 5, 2014

Projects

None yet

3 participants

@ed-was-here
Contributor

fixes issue #1932 - ofxAssimpModelLoader example fails on Windows when loading 3DS model (when pressing '5')
Models were being loaded in text mode instead of binary mode causing issues with binary formats like .3ds.

@ed-was-here ed-was-here Update ofxAssimpModelLoader.cpp
Load models in binary, not text mode.  fixes issue #1932 - ofxAssimpModelLoader example fails when loading 3DS model (when pressing '5')
aac4078
@arturoc arturoc merged commit d2a235d into openframeworks:master Mar 5, 2014
@bilderbuchi
Member

so, @arturoc, is it ok to load text files in binary mode, on every platform?

@arturoc
Member
arturoc commented Mar 5, 2014

yes it's ok, indeed we should have binary mode as default, libraries shouldn't care about breaklines being \n or \r\n when reading text files and if you are reading a unix text file in windows or viceversa then it's more obvious that you need to set not binary mode, we could even change the name of that parameter to convertBreaklines since that's all it does and binary is kind of confusing

@bilderbuchi
Member

still, it's common parlance, and the fstream parameter is also called (ios::)binary, so I'd rather keep it that way, to increase the probability of finding information about it on the net.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment