Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring ofxGui #4306

Closed
Closed

Conversation

@frauzufall
Copy link
Contributor

@frauzufall frauzufall commented Aug 27, 2015

Refactored ofxGui version with new controls, layouts, options..

arturoc and others added 30 commits Jul 24, 2015
…o refactor-gui

Conflicts:
	addons/ofxGui/src/ofxGuiGroup.cpp
	addons/ofxGui/src/ofxGuiGroup.h
Conflicts:
	libs/openFrameworks/types/ofParameter.h
…g in separate functions to simplify inheritance
@frauzufall
Copy link
Contributor Author

@frauzufall frauzufall commented Jan 1, 2016

@tpltnt I tested this using a pretty complex scenario and found some flaws that had to be addressed. We did this in a Berlin meet-up a few weeks ago and made a plan (~ http://piratepad.net/oWFWVyvdb9) So it might take a little longer to complete this.

@arturoc the json lib isn't part of the core yet, is it?

@ofZach
Copy link
Contributor

@ofZach ofZach commented Jan 1, 2016

re: json this library seems promising:
https://github.com/nlohmann/json

@frauzufall
Copy link
Contributor Author

@frauzufall frauzufall commented Jan 1, 2016

Jepp, I think that's the one we talked about :)

@arturoc
Copy link
Member

@arturoc arturoc commented Jan 1, 2016

yes that's the one we are going to include i think the syntax is really nice so we don't even need to wrap it or anything just have it there so we give support for json in the core and addons.

@tpltnt we are on a patch only release cycle right now:

https://github.com/openframeworks/openFrameworks/milestones/0.9.1

once the remaining issues are closed we'll release 0.9.1 and then we can begin to merge the PRs milestoned for 0.10 like this one. in general take a look at the milestoned bugs to see what's scheduled for the current release cycle

@arturoc arturoc added this to the 0.10.0 milestone Feb 2, 2016
@tpltnt
Copy link
Contributor

@tpltnt tpltnt commented Feb 13, 2016

what is left to do to merge this pull request?

@frauzufall
Copy link
Contributor Author

@frauzufall frauzufall commented Feb 13, 2016

TODO:

  • Config classes need to be changed into JSON attributes (I will be working on that)
  • the example application in examples/gui/advancedGuiExample freezes on exit and I can't find a way to resolve this (help is very much welcome, I already wrote @arturoc)
  • since this PR changes ofxGui quite a bit we also wanted to give it a modern look ( @fx-lange wanted to ask someone with design background)

There are more requests and enhancements but they will not be part of this PR. The aim of this PR is to provide a gui that is highly extensible and to apply this extensibility by adding more controls and containers.

@brucelane
Copy link

@brucelane brucelane commented Feb 23, 2016

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.