Refactoring ofxGui #4306

Closed
wants to merge 84 commits into
from

Conversation

Projects
None yet
6 participants
@frauzufall
Contributor

frauzufall commented Aug 27, 2015

Refactored ofxGui version with new controls, layouts, options..

arturoc and others added some commits Jul 24, 2015

Merge branch 'master' of github.com:openframeworks/openFrameworks int…
…o refactor-gui

Conflicts:
	addons/ofxGui/src/ofxGuiGroup.cpp
	addons/ofxGui/src/ofxGuiGroup.h
Merge branch 'master' into refactor-gui
Conflicts:
	libs/openFrameworks/types/ofParameter.h
fixup! adds option to hide header, moves header generating and drawin…
…g in separate functions to simplify inheritance
set rotary slider default height, changed add function without config…
… to use GuiType::Config instead of parent Config
Merge remote-tracking branch 'arturoc/refactor-gui' into refactor-gui…
…-extended

Conflicts:
	addons/ofxGui/src/ofxBaseGui.cpp
	addons/ofxGui/src/ofxBaseGui.h
fixes, adaption to https://github.com/arturoc/ofxGuiExtended/, mergin…
…g ofxSlider and ofxVerticalSlider, removing ofxGuiGraphics and ofxGuiZoomableGraphics
Merge remote-tracking branch 'upstream/master' into refactor-gui-exte…
…nded

Conflicts:
	addons/ofxGui/src/ofxBaseGui.cpp
	addons/ofxGui/src/ofxBaseGui.h
	addons/ofxGui/src/ofxGuiGroup.cpp
	addons/ofxGui/src/ofxGuiGroup.h
@tpltnt

This comment has been minimized.

Show comment
Hide comment
@tpltnt

tpltnt Dec 31, 2015

Contributor

@arturoc what is blocking this pull request from being merged?

Contributor

tpltnt commented Dec 31, 2015

@arturoc what is blocking this pull request from being merged?

@frauzufall

This comment has been minimized.

Show comment
Hide comment
@frauzufall

frauzufall Jan 1, 2016

Contributor

@tpltnt I tested this using a pretty complex scenario and found some flaws that had to be addressed. We did this in a Berlin meet-up a few weeks ago and made a plan (~ http://piratepad.net/oWFWVyvdb9) So it might take a little longer to complete this.

@arturoc the json lib isn't part of the core yet, is it?

Contributor

frauzufall commented Jan 1, 2016

@tpltnt I tested this using a pretty complex scenario and found some flaws that had to be addressed. We did this in a Berlin meet-up a few weeks ago and made a plan (~ http://piratepad.net/oWFWVyvdb9) So it might take a little longer to complete this.

@arturoc the json lib isn't part of the core yet, is it?

@ofZach

This comment has been minimized.

Show comment
Hide comment
@ofZach

ofZach Jan 1, 2016

Contributor

re: json this library seems promising:
https://github.com/nlohmann/json

Contributor

ofZach commented Jan 1, 2016

re: json this library seems promising:
https://github.com/nlohmann/json

@frauzufall

This comment has been minimized.

Show comment
Hide comment
@frauzufall

frauzufall Jan 1, 2016

Contributor

Jepp, I think that's the one we talked about :)

Contributor

frauzufall commented Jan 1, 2016

Jepp, I think that's the one we talked about :)

@arturoc

This comment has been minimized.

Show comment
Hide comment
@arturoc

arturoc Jan 1, 2016

Member

yes that's the one we are going to include i think the syntax is really nice so we don't even need to wrap it or anything just have it there so we give support for json in the core and addons.

@tpltnt we are on a patch only release cycle right now:

https://github.com/openframeworks/openFrameworks/milestones/0.9.1

once the remaining issues are closed we'll release 0.9.1 and then we can begin to merge the PRs milestoned for 0.10 like this one. in general take a look at the milestoned bugs to see what's scheduled for the current release cycle

Member

arturoc commented Jan 1, 2016

yes that's the one we are going to include i think the syntax is really nice so we don't even need to wrap it or anything just have it there so we give support for json in the core and addons.

@tpltnt we are on a patch only release cycle right now:

https://github.com/openframeworks/openFrameworks/milestones/0.9.1

once the remaining issues are closed we'll release 0.9.1 and then we can begin to merge the PRs milestoned for 0.10 like this one. in general take a look at the milestoned bugs to see what's scheduled for the current release cycle

@arturoc arturoc added this to the 0.10.0 milestone Feb 2, 2016

@frauzufall frauzufall referenced this pull request in frauzufall/ofxGuiExtended Feb 6, 2016

Closed

merge gui extensions #26

@tpltnt

This comment has been minimized.

Show comment
Hide comment
@tpltnt

tpltnt Feb 13, 2016

Contributor

what is left to do to merge this pull request?

Contributor

tpltnt commented Feb 13, 2016

what is left to do to merge this pull request?

@frauzufall

This comment has been minimized.

Show comment
Hide comment
@frauzufall

frauzufall Feb 13, 2016

Contributor

TODO:

  • Config classes need to be changed into JSON attributes (I will be working on that)
  • the example application in examples/gui/advancedGuiExample freezes on exit and I can't find a way to resolve this (help is very much welcome, I already wrote @arturoc)
  • since this PR changes ofxGui quite a bit we also wanted to give it a modern look ( @fx-lange wanted to ask someone with design background)

There are more requests and enhancements but they will not be part of this PR. The aim of this PR is to provide a gui that is highly extensible and to apply this extensibility by adding more controls and containers.

Contributor

frauzufall commented Feb 13, 2016

TODO:

  • Config classes need to be changed into JSON attributes (I will be working on that)
  • the example application in examples/gui/advancedGuiExample freezes on exit and I can't find a way to resolve this (help is very much welcome, I already wrote @arturoc)
  • since this PR changes ofxGui quite a bit we also wanted to give it a modern look ( @fx-lange wanted to ask someone with design background)

There are more requests and enhancements but they will not be part of this PR. The aim of this PR is to provide a gui that is highly extensible and to apply this extensibility by adding more controls and containers.

@brucelane

This comment has been minimized.

Show comment
Hide comment

+1

@frauzufall frauzufall referenced this pull request Apr 9, 2016

Closed

ofxGui refactoring #2 #5041

@frauzufall frauzufall closed this May 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment