Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rpi4 #6325

Open
wants to merge 5 commits into
base: master
from

Conversation

@eshkrab
Copy link

commented Jul 4, 2019

some attempts at making oF work on raspberry pi 4, as per discussion here. Everything compiles (as TARGET_LINUX, not TARGET_RASPBERRY_PI) but currently fails at runtime with a segfault because unable to init GLFW

@@ -61,7 +61,7 @@ common:
# ADDON_LIBS_EXCLUDE =

linux64:
ADDON_PKG_CONFIG_LIBRARIES = opencv4 harfbuzz
ADDON_PKG_CONFIG_LIBRARIES = opencv harfbuzz

This comment has been minimized.

Copy link
@arturoc

arturoc Jul 4, 2019

Member

this should be kept as opencv4 you might have commited it after the install_dependencies script changes it cause opencv4 is not yet avaliable on the pi.

reverting it to opencv4 should fix some of the issues in other platforms

This comment has been minimized.

Copy link
@eshkrab

eshkrab Jul 4, 2019

Author

ooh, I was wondering how that file got changed without me touching it

#elif defined(TARGET_EMSCRIPTEN)
shared_ptr<ofxAppEmscriptenWindow> window = std::make_shared<ofxAppEmscriptenWindow>();
#elif defined(TARGET_OPENGLES)
shared_ptr<ofAppGLFWWindow> window = std::make_shared<ofAppGLFWWindow>();
#else
#elif defined(TARGET_LINUX)

This comment has been minimized.

Copy link
@arturoc

arturoc Jul 4, 2019

Member

this should just be an else, otherwise windows and osx are not considered

#ifdef TARGET_LINUX_ARM
#ifdef TARGET_RASPBERRY_PI
// #ifdef TARGET_RASPBERRY_PI

This comment has been minimized.

Copy link
@arturoc

arturoc Jul 4, 2019

Member

this should be kept as it was and the include for bcm_host above removed, since it only belongs to the PI not to general linux. Also the define countof. if it's needed at all should go here not in the general linux section

This comment has been minimized.

Copy link
@eshkrab

eshkrab Jul 4, 2019

Author

so If I'm trying to compile with TARGET_LINUX, what'd be the right way to stick that countof undefine?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.