added ofDrawGrid to complement ofDrawAxis. added 'get' accessors to ofCam #726

Merged
merged 3 commits into from Feb 9, 2012

Conversation

Projects
None yet
3 participants
Contributor

elliotwoods commented Sep 3, 2011

added ofDrawGrid to complement ofDrawAxis. added 'get' accessors to ofCamera's internal properties, made ofCamera's internal properties protected rather than private

@elliotwoods elliotwoods added ofDrawGrid to complement ofDrawAxis. added 'get' accessors to o…
…fCamera's internal properties, made ofCamera's internal properties protected rather than private
be83edd
Contributor

ofTheo commented Sep 3, 2011

is this missing a grid for one of the axis though?
shouldn't there be a third one for z ?

Contributor

elliotwoods commented Sep 3, 2011

then would be 2 more (xz,xy,yz) ?

Contributor

elliotwoods commented Sep 3, 2011

perhaps could make a scaled line in +/- y rather than a full grid

Owner

bilderbuchi commented Sep 3, 2011

why the change to protected, when you add accessor functions anyway?

Contributor

elliotwoods commented Sep 3, 2011

specifically the projection matrices
it doesn't make much sense to allow people to externally set the projection matrix of a camera
but if they make their own camera inheriting ofCamera, then they should be able to (which was necessary for me yesterday)

Owner

bilderbuchi commented Sep 4, 2011

ah, ic.

Contributor

ofTheo commented Oct 19, 2011

can we get the ofDrawGrid(bool, bool, bool) for each axis? with defaults to true.
same for ofDrawAxis

bilderbuchi referenced this pull request Dec 3, 2011

Closed

PR tracking issue #835

@ofTheo ofTheo added a commit that referenced this pull request Feb 9, 2012

@ofTheo ofTheo Merge pull request #726 from elliotwoods/ofDrawGrid
added ofDrawGrid to complement ofDrawAxis. added 'get' accessors to ofCam
7ca7833

@ofTheo ofTheo merged commit 7ca7833 into openframeworks:master Feb 9, 2012

Contributor

elliotwoods commented Feb 21, 2012

hey!
i'd totally forgotten about this

line 57 has an error
it says
drawGridPlane where it should say ofDrawGridPlane

this is fixed in
#924

i see this is pulled this master though rather than develop
apologies for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment