From 04a4588b3d2b5667fac6d4fb7183735ae6b28fb0 Mon Sep 17 00:00:00 2001 From: 1000ch Date: Mon, 11 Dec 2017 13:37:43 +0900 Subject: [PATCH] Set display empty string as default --- src/index.js | 10 ++++++---- test/index.js | 5 ++++- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/src/index.js b/src/index.js index 3da71c5..f5d9d06 100644 --- a/src/index.js +++ b/src/index.js @@ -31,7 +31,7 @@ export default class ViewportObserver extends React.Component { static defaultProps = { tagName : 'div', - display : 'block', + display : '', onChange : () => {}, onEnter : () => {}, onLeave : () => {}, @@ -105,9 +105,11 @@ export default class ViewportObserver extends React.Component { props[key] = this.props[key]; }); - props.style = { - display : this.props.display - }; + if (this.props.display !== '') { + props.style = { + display : this.props.display + }; + } return React.createElement(this.props.tagName, { ...props, diff --git a/test/index.js b/test/index.js index 37e093d..abc0aed 100644 --- a/test/index.js +++ b/test/index.js @@ -19,11 +19,14 @@ describe('ViewportObserver', () => { document.body.removeChild(div); }); - it('should be rendered as div default', () => { + it('should be rendered with default values', () => { const component = TestUtils.renderIntoDocument(); const node = TestUtils.findRenderedDOMComponentWithTag(component, 'div'); assert.notEqual(node, null); + + assert.equal(node.className, ''); + assert.equal(node.style.display, ''); }); it('should be rendered as specified `tagName`', () => {