Skip to content

Translate all out-of-game UI (start screen, lobbies, etc.)#316

Merged
evanpelle merged 46 commits into
openfrontio:mainfrom
Aotumuri:mls
Mar 25, 2025
Merged

Translate all out-of-game UI (start screen, lobbies, etc.)#316
evanpelle merged 46 commits into
openfrontio:mainfrom
Aotumuri:mls

Conversation

@Aotumuri

@Aotumuri Aotumuri commented Mar 23, 2025

Copy link
Copy Markdown
Member

This PR adds full translation support for all out-of-game UI elements,
including the start screen, public/private lobby modals, and other pre-game interfaces.

All static text has been externalized to en.json and ja.json for future language support.
If you find any spots that are not yet translated (missing from the JSON), please let me know.
Thanks a lot!

This is a follow-up to PR #305.

@Aotumuri

Copy link
Copy Markdown
Member Author

⚠️ The structure of the difficulty levels in the JSON file has been changed.
The "difficulty" object is no longer in its previous location.

Apologies to anyone who was working on this — please note the update!

@Aotumuri

Copy link
Copy Markdown
Member Author

Also includes support for the newly added Austria map.
スクリーンショット 2025-03-23 11 14 53

@Aotumuri

Copy link
Copy Markdown
Member Author

I’ve resolved the issue where translations weren’t working properly on openfront.dev.
(For some reason, even though everything worked fine in my local environment using npm run dev, there was a strange behavior where lang.js was being overwritten by HTML, which caused the translation feature to fail.)
Now that I’ve embedded the JS directly into the HTML, it should work as expected.

I’d appreciate it if this pull request could be merged before the changes are pushed to openfront.io!

@Aotumuri

Aotumuri commented Mar 23, 2025

Copy link
Copy Markdown
Member Author

Bulgarian is also supported, but the JSON file is in #314, so that will be needed as well.

cldprv and others added 2 commits March 23, 2025 15:04
Add french translation.
Add French language support
@Aotumuri

Copy link
Copy Markdown
Member Author

Thanks to cldprv, French language support has been added. Really appreciate your contribution! 🇫🇷

@Aotumuri

Copy link
Copy Markdown
Member Author

daimyo_panda2 helped correct the Japanese translation!🇯🇵
I really appreciate it!

I don't know any more languages, I will stop here. Thinking about improving the UI, it doesn't look very great on Firefox.
Everythings works, and I think I runned prettier this time, so should be able to merge without problems.
Comment thread src/client/index.html Outdated
@evanpelle

Copy link
Copy Markdown
Collaborator

Thanks! This is very helpful! Mind running npm run format to format the files

@evanpelle evanpelle merged commit 9088ade into openfrontio:main Mar 25, 2025
evanpelle pushed a commit that referenced this pull request Mar 25, 2025
Adding the base bulgarian language json file and making it usable in
game. This PR is building on top of the multi language support PR. Note:
Needs PR #316 to work!
@Aotumuri Aotumuri linked an issue May 27, 2025 that may be closed by this pull request
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MLS

4 participants