replaces player names with randomized name

[Aotumuri]

This PR replaces player names with randomized name
The goal is to reduce exposure to inappropriate or offensive names.
Additionally, content creators no longer need to worry about displaying other players’ usernames.


Use the upper left button (Ninja) to change settings.

Fixes #489

[Aotumuri]

This PR is my first change of code in the game.
I have debugged it on my end, but I would like to see it in someone else's environment as well, so if you are willing to help, please do.
Thanks!

...
um..
In other words, I don't think the merge should be done once.

[Aotumuri]

I've had a few people debug it, but more are needed.
But so far no problems have been reported so I think we are good to go.

[Aotumuri]

Since I’m using localStorage, I understand that a bug can occur when playing the game in multiple tabs of the same browser.
Should I fix this issue?
I’m planning to fix it if playing in multiple tabs is considered a legitimate use case.

[VariableVince]

Players call each other out like 'GG' in discord with screenshot of game. Or a youtuber says "[player name] is good" in their vid. Etc. Is there a way for recognizability to still be possible? A user knowing their random name for example, by assigning them the same name each time? Or some other unique identifier.

I may be totally wrong here and misinterpreting this PR, in that case sorry

[Aotumuri]

Players call each other out like 'GG' in discord with screenshot of game. Or a youtuber says "[player name] is good" in their vid. Etc. Is there a way for recognizability to still be possible? A user knowing their random name for example, by assigning them the same name each time? Or some other unique identifier.

Random names are generated each time on the client side of each game.
So it is difficult to know who is who.

[Aotumuri]

Bot names are now underlined.

[Aotumuri]

Player names are in bold.

[Aotumuri]

Perspectives from test_name. (RandomName on)

Perspectives from Anon826. (RandomName off)

[VariableVince]

Random names are generated each time on the client side of each game. So it is difficult to know who is who.

Yeah so each player each game will see their own randomized set of player names on their own screen. I could see it have an effect on player engagement, not being able to recognize eachother. While i also see the positives in no offensive names. Not one of the developers though (yet) and this may have already been discussed with Evan, so just my two cents.

(There's work being done on a discord login, which could be tied to a saved random name that stays with a player longer but i don't know. And you cannot force login or discord account maybe. Also there's work on clans with tags which may interfere.)

[Aotumuri]

If a team mode is implemented, should we put in a process to remove the random when the same team is used?

[VariableVince]

Good idea and i like seeing who is bot or player by underlined/bold name.

Also, maybe let player toggle random names on or off? A streamer not wanting to show offensive names, toggles random names on. A player sitting home alone and not really caring what they see, toggles random names off.

Then you still have the 'recognizability issue' (if it even is the issue i make of it) but user has a choice at least. But offensive names may still end up in screenshots shared and damage OpenFront rep.

Or, again, some way to do this but server side to keep track and assign the same random name to each player as much as possible. And show the player what name is displayed at others' screens.

Or only offensive names are randomized so only they suffer from not being recognizable, but that's basically what's already being done and hard to filter everything out.

[Aotumuri]

You can change this system on the start screen.

[Aotumuri]

Bot will use italics

[Aotumuri]

Right now, I’m using randomized bot-style names to hide player identities.
However, someone suggested that a single, memorable word — like a flower name — might be better.
Which approach do you think works best?

[evanpelle]

Instead of using Math.random, hash the name using simpleHash() function (should be in Util.ts) and use the hash to get a random name. Having repeatable names is important, especially when replaying games.

[evanpelle]

Instead of putting in the top left, why not include it in the settings?

[icslucas]

Everything looks good, works in game and no bugs where found.

[Aotumuri]

I’ve updated everything except the part that fetches the username from local storage.
Please take a look and let me know if it looks good.

[Aotumuri]

I’ve addressed all the comments—either by making changes or replying to them.

[samisbakedham]

Is this off by default?

[Aotumuri]

Is this off by default?

ofc, this is off by default

[APuddle210]

I’ve addressed all the comments—either by making changes or replying to them.

@Aotumuri, you should also click the 'resolve' button. If there are any unresolved when Evan approves it, it won't merge. Even after approving them again, Evan will have to come back to specifically merge it. A couple PRs from early march never got merged, despite being approved, I think because of this.

[Aotumuri]

[Aotumuri]

@evanpelle I fixed

[evanpelle]

thanks!