MLS-PACK

[Aotumuri]

Please complete the following:

• I have added screenshots for all UI updates
• I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced
• I understand that submitting code with bugs that could have been caught through manual testing blocks releases and new features for all contributors

This is commit pack
This PR refactors and improves the language selection experience:
• Centralizes all language-related logic in LangSelector.ts & LanguageModal.ts
• Redesigns the language selection UI for better UX across devices
• Adds new translations and supports more languages
Changes .w.
• Language selection is now handled entirely inside LangSelector.ts & LanguageModal.ts
• Prevents background scrolling when open
• Highlights the current language at the top
• Always shows English second
• Shows browser language third (if different from current)
• All other languages are sorted alphabetically by English name
• Debug option is shown at the end when pressing D
• The language list is scrollable when it exceeds screen height

Supported Languages
["en", "ja", "fr", "bg", "nl", "ru", "ua", "de"]

Added Translation Keys

"lang": {
  "en": "English",
  "native": "English",
  "svg": "xx"
},
"map": {
  "map": "Map"
},
"game_starting_modal": {
  "title": "Game is Starting...",
  "desc": "Preparing for the lobby to start. Please wait."
},
"difficulty": {
  "difficulty": "Difficulty"
}

Please put your Discord username so you can be contacted if a bug or regression is found:

MLS Representative

• aotumuri

Translation collaborator

• Nikola123 (He was a very big help from setting up the translation site to adding the json. Thank you so much!)
  I don't have permission from my collaborators to display their names here, so I'll put the discord link here
  https://discord.com/channels/1284581928254701718/1352553113612980224/1352553113612980224
• tryout33

Collaborators from other servers.

• CCC Group (This is not Culture Convenience Club. Think of it like a server where developers of various games are playing.)
• People who fixed the UI and found bugs.
  meow02952 (discord id) <- This person also gave me a code suggestion. Thanks!
  moon_spear (discord id)
  ww_what_ww (discord id)
  Azuna (he doesn't have discord account)
• People who corrected translations, etc.
  kyoyume (discord id)
  ultrasuper (discord id)
  grueg (he doesn't have discord account)

If I forgot to include your name, or if you’d like your name to be added, please let me know via Gmail or Discord.

[Aotumuri]

DO NOT MERGE PLZ

[evanpelle]

DO NOT MERGE PLZ

lmk when it's ready

[Aotumuri]

I can't debug because I can't use npm run dev.
I am looking for a way to use it again and I think it will be no longer a problem in a few days.

start:client
webpack serve --open --node-env development
sh: webpack: command not found

[Aotumuri]

I don't think it is a problem now! Thanks for waiting.
@evanpelle

[Aotumuri]

Is this my fault? I'm getting an error in an unrelated area.

[evanpelle]

Please add a summary in the description. I also updated the translation code, I put it in LangSelector.ts, so you'll need to put all language related code there.

[Aotumuri]

This PR refactors and improves the language selection experience:
• Centralizes all language-related logic in LangSelector.ts & LanguageModal.ts
• Redesigns the language selection UI for better UX across devices
• Adds new translations and supports more languages
Changes .w.
• Language selection is now handled entirely inside LangSelector.ts & LanguageModal.ts
• Prevents background scrolling when open
• Highlights the current language at the top
• Always shows English second
• Shows browser language third (if different from current)
• All other languages are sorted alphabetically by English name
• Debug option is shown at the end when pressing D
• The language list is scrollable when it exceeds screen height

Supported Languages
["en", "ja", "fr", "bg", "nl", "ru", "ua", "de"]

Added Translation Keys

"lang": {
  "en": "English",
  "native": "English",
  "svg": "xx"
},
"map": {
  "map": "Map"
},
"game_starting_modal": {
  "title": "Game is Starting...",
  "desc": "Preparing for the lobby to start. Please wait."
},
"difficulty": {
  "difficulty": "Difficulty"
}

[Aotumuri]

I fixed all!
@evanpelle

[Aotumuri]

The following version of the MLS-pack has been merged
#355 (comment)

[6uzm4n]

Everything looks good. I can't do a test run right now but I assume you've tested this through!

[Aotumuri]

@evanpelle
ready for merge

[evanpelle]

this is the wrong id, this should be singleplayer-modal-

and the HostLobbyModal should be host-modal-

[Aotumuri]

I fixed all!
This PR is ready to merge!
@evanpelle