Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰(dogwood/3/fun) pin django-classy-tags version to 0.8.0 #248

Merged
merged 4 commits into from Sep 8, 2020

Conversation

madmatah
Copy link
Contributor

@madmatah madmatah commented Sep 8, 2020

Purpose

Recent builds of dogwood.3-fun install django-classy-tags 2.0.0, that is not compatible anymore with python 2.x.

Same problem with eucalyptus flavor.

Proposal

  • (eucalyptus + dogwood) pin django-classy-tags version to 0.8.0
  • bump to dogwood.3-fun-1.14.1
  • bump to eucalyptus.3-wb-1.9.3

@madmatah madmatah added the bug label Sep 8, 2020
@madmatah madmatah self-assigned this Sep 8, 2020
@sampaccoud
Copy link
Contributor

sampaccoud commented Sep 8, 2020

@madmatah I think the other flavors will have the same problem!?

@madmatah
Copy link
Contributor Author

madmatah commented Sep 8, 2020

@madmatah I think the other flavors will have the same problem !?

Thanks ! I checked after your comment :

On Hawthorn :

It seems to be OK because django-classy-tags is pinned to 0.8.0 in base requirements.

openedx-docker$ grep classy-tags releases/hawthorn/1/oee/src/edx-platform/requirements/edx/base.txt 
django-classy-tags==0.8.0  # via django-sekizai

On Eucalyptus :

The installed version is 2.0.0 and need to be pinned, yep.
I'll do it in this PR.

@sampaccoud
Copy link
Contributor

So should we pin it to 0.8 instead if that's what Hawthorn is running on!?

@madmatah
Copy link
Contributor Author

madmatah commented Sep 8, 2020

So should we pin it to 0.8 instead if that's what Hawthorn is running on!?

@sampaccoud Yes we can do that to be sure.
But I don't see any impacting change in their Changelog between 0.8.0 and 1.0.0

@sampaccoud sampaccoud changed the title 馃悰(dogwood/3/fun) pin django-classy-tags version to 1.0.0 馃悰(dogwood/3/fun) pin django-classy-tags version to 0.8.0 Sep 8, 2020
`django-classy-tags` 2.0.0 dropped support for python 2.x. As a
result, we get fatal errors in our recent builds. We pin it to version
0.8.0 because that's the version used in hawthorn base requirements.
Fixed

- Pin django-classy-tags to 1.0.0 to avoid breaking changes in 2.0.0
`django-classy-tags` 2.0.0 dropped support for python 2.x. As a
result, we get fatal errors in our recent builds. We pin it to version
0.8.0 because that's the version used in hawthorn base requirements.
Fixed

- Pin django-classy-tags to 0.8.0 to avoid breaking changes
@madmatah
Copy link
Contributor Author

madmatah commented Sep 8, 2020

Done!

I'm ready for a final review if the CI checks pass 馃檪

@sampaccoud
Copy link
Contributor

@madmatah are the bare flavors not concerned?

@madmatah
Copy link
Contributor Author

madmatah commented Sep 8, 2020

@madmatah are the bare flavors not concerned?

You're right, dogwood/3/bare and eucalyptus/3/bare are also affected by this problem.
But in order to fix it, a change needs to be made in the bare flavors to be able to add custom dependencies.
I created #249 to deal with this problem in another PR.

@madmatah madmatah merged commit 4708a46 into master Sep 8, 2020
@madmatah madmatah deleted the dogwood-fun-pin-classy-tags branch September 8, 2020 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants