Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only remove packages that are part of the variant being installed. Unless explicitly defined with a keyword. #324

Closed
9 tasks done
msfjarvis opened this issue Jun 6, 2016 · 10 comments

Comments

@msfjarvis
Copy link

msfjarvis commented Jun 6, 2016

Only issues related to the code of The Open GApps Project scripts themselves
If you have found an issue with a pre-built OpenGApps.org package please use XDA Forum

Checklist

  • The issue is not answered by reading the FAQ
  • The issue is part of The Open GApps Project scope (and not of the pre-built OpenGApps.org packages scope, for support on those see XDA Forum)

If Open GApps compilation fails:

~If Open GApps installation fails:

  • Is the issue reproducible using the latest version of your recovery?
  • Is the issue reproducible with (the latest) TWRP recovery? (other recoveries are only best-effort)~

~If receiving force closures after Open GApps installation:

  • The issue is NOT an error within one of the bundled Google applications itself (verify by e.g. installing the application from the Play Store instead)
  • The issue is reproducible on clean (=wiped /data/ partition) installation
  • The affected ROM includes the necessary patches and functionality as noted for Android versions and Platforms
  • No non-AOSP hacks like privacy guards' permission restrictions etcetera are applied~

Issue description:
I installed the OpenGapps nano package onto my stock ROM (clean AOSP, Android One second gen MTK variant) to update the core apps like Play Store, Google etc. When I booted back into AOSP, my Google Now Launcher was gone, so was Keep and Gmail.

Reproduction Steps:

  1. Install OpenGapps nano package over a clean AOSP factory ROM
  2. Boot back to find apps mentioned above missing.

Expected behavior:

Only the apps the Installer is adding should have been removed

Observed behavior:

But it did a general cleanup from what I can deduce.

Installation debug log and logcat of FC:

Debug log of the Open GApps installation

@mfonville
Copy link
Member

Where you apps installed on /system? Because Open GApps currently doesn't (and can't) differentiate between wanting to remove an app, or not wanting to update an app. So it removes any app on /system that is part of the Open GApps installation options (including the bigger packages).

@msfjarvis
Copy link
Author

I'm assuming the "Where you" is a typo that means "Were your". Yes, they were all on /system, and OpenGapps did kill off all Google Apps it found (Thanks for that, I was being a bit lazy to remove the extra Play Movies and other bloat :p )

@msfjarvis
Copy link
Author

But I kinda like and use Keep and Gmail, so it's a :( for removing them too...

@msfjarvis
Copy link
Author

@opengapps/developers is this something we can expect to be ever added into the installer?

@mfonville
Copy link
Member

@MSF-Jarvis indeed I meant 'were'.
I think we will probably change this yes. The current behaviour is according to how PA GApps behaved, but it does not match people's expectations.
I guess we will do this when we are going to revise the current package sets, names and the config.

I will update the description accordingly.

@mfonville mfonville changed the title Smaller packages remove apps they don't install Only remove packages that are part of the variant being installed. Unless explicitly defined with a keyword. Jun 7, 2016
@msfjarvis
Copy link
Author

Thanks @mfonville. We should keep this open,no?

@mfonville
Copy link
Member

@MSF-Jarvis we keep this open as tracking bug

@msfjarvis
Copy link
Author

@mfonville any headstart with this?

@mfonville
Copy link
Member

@MSF-Jarvis not yet, some recent health issues have severely slowed down my pace of development :(

@msfjarvis
Copy link
Author

Looks like this is fixed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants