Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring up OpenGApps to support Android 9.0 (1/4) #657

Merged
merged 28 commits into from Sep 5, 2018

Conversation

@SpasilliumNexus
Copy link
Contributor

@SpasilliumNexus SpasilliumNexus commented Sep 1, 2018

Changes:

Enable OpenGApps support for Android 9.0 Pie

Create symlink for SetupWizard on Android 9.0 (ARM64)

Limit SetupWizard library to Android 9.0 (ARM64)

  • This library only has an ARM64 variant. No info is known on exactly what it does, but we'll include it just in case to avoid any issues.

Add new and updated permissions, sysconfig from Android 9.0

Only com.google.android.dialer.support.xml is in Android 9.0

  • dialer_experience.xml is not needed anymore since this file has the same permissions and is redundant with 9.0

Add additional sysconfigs for Pixel devices

  • These files contain additional permissions and features exclusively for Pixel

Add additional sysconfig for enabling Google exclusives on non-Google devices

  • Some Pixel features such as Digital Wellbeing and exclusive Wallpaper categories work with no problem on non-Google devices

Remove uneeded 2017 camera permission and jar

  • To this day these files still have issues with launching the Google Camera app

Install legacy GMSSetup only on Android 8.0 & 8.1

  • This is no longer included in Android 9.0

Play Services folder name is PrebuiltGmsCorePi on Android 9.0

Add & separate Android Platform Services between Android 8.0 & 9.0

  • There are two separate package names between the versions. 8.0 using "com.google.android.gms.policy_sidecar_o" and 9.0 using "com.google.android.gms.policy_sidecar_aps". With Android 9.0, not having this app brought random FCs about it being missing during SetupWizard.

Add Data Transfer Tool to Android 9.0 (Core)

  • Not having this included prevents users from restoring their device's apps, settings, etc in Android 9.0. Moved to Core in a later commit.

Add Actions Services to Android 9.0 (Super/Aroma)

  • This app is what enables text selection while in the overview/recents screen.

Add Google Sound Picker to Android 9.0 (Super/Aroma)

  • Not having this app prevented users from selecting alarms, ringtones, and/or notification sounds in apps such as Google Clock. Also, if this installed, Android 9.0 uses it by default. Moved to Core in a later commit.

Add Better Together to Android 9.0 (Super/Aroma)

  • This app allows integration with Chrome OS such as Android Messages and Instant Tethering.

Add Digital Wellbeing to Android 9.0 (Super/Aroma)

  • This app allows the user to set and monitor their device usage. It also works on devices other than a Pixel.

Add Markup to Android 9.0 (ARM64) (Super/Aroma)

  • This app allows the user to highlight and draw on their screenshots by tapping edit below the screenshot in the notification pulldown. Working only on ARM64 devices due to the required library that's used with the app. Moved to Core in a later commit.

Fix indentation automatically created with Notepad++

Remove duplicate statement in installer, fix typo in Aroma

Search in more locations for gapps-config (/data)

  • In addition to the current locations, /data was added for those who create "auto-installers" that copy a gapps-config file to the root of that location.

Apply correct permission to build.prop on Android 8.0+

  • Not having this permission applied causes some devices to not boot.

Repair missing check entries in inc.aromadata.sh

Move Google Sound Picker to Core

  • See "Add Google Sound Picker to Android 9.0 (Super/Aroma)"

GoogleLoginService is no longer available in Android 8.0+

  • GoogleServicesFramework takes place of this app since 8.0

Move Digital Wellbeing to Core

  • See "Add Digital Wellbeing to Android 9.0 (Super/Aroma)"

Move Markup to Core

  • See "Add Markup to Android 9.0 (ARM64) (Super/Aroma)"

Installer: Replace all instances of "insure" to "ensure"

Compatibility: Replace all instances of "insure" to "ensure"

nezorflame and others added 28 commits Aug 11, 2018
SpasilliumNexus edit: added what we also include for api28hack
… devices
@SpasilliumNexus
Copy link
Contributor Author

@SpasilliumNexus SpasilliumNexus commented Sep 1, 2018

NOTES:

Edit: See update post below

The only current issue with this bringup is some ARM devices cannot get past signing into their Google Account, whether it be during SetupWizard, or a Google app that requires signing in on Android 9.0.

I've given/suggested every kind of potential solution with solving the problem that I can think of, from renaming/deleting apps, to going back to Oreo core files, but nothing solved it.

The two known devices to suffer from this are the Lenovo A6000 (phone), and Xiaomi MiPad 1 (tablet).

It should be known that a report of the 2013 Moto G, also an ARM device, works just fine.

I have attached logcats of both devices below in case anyone wants to see what's going on, and (hopefully) have a solution.

@SpasilliumNexus
Copy link
Contributor Author

@SpasilliumNexus SpasilliumNexus commented Sep 2, 2018

Update

The signing in issue has been fixed for MiPad1 users! Now I'm just waiting for the Lenovo A6000 users to get the same treatment and have it fixed on their ROM(s) too.

EDIT: Turns out the both devices are maintained by one person, who have/will have the issue resolved on both!

The common problem between both were:

webview_zygote: jni_internal.cc:616] JNI FatalError called: (com.google.android.webview:sandboxed_process0) Failed open(/sys/kernel/debug/tracing/trace_marker, 1): Permission denied

@nezorflame
Copy link
Contributor

@nezorflame nezorflame commented Sep 5, 2018

+1 to that.
@SpasilliumNexus did a tremendous amount of work.
@mfonville @NicholasBuse any news on merging this and https://github.com/opengapps/all/pull/24?

@NicholasBuse
Copy link
Contributor

@NicholasBuse NicholasBuse commented Sep 5, 2018

Yes Tommy did! Thanks!

I spent some time yesterday building legacy builds pre- and post- Tommy's PRs. The 9.0 stuff looks good, I'm just checking older builds, especially when files (*.xml) go away...

I hope to complete today and ping @mfonvile to update the build server.

@nezorflame
Copy link
Contributor

@nezorflame nezorflame commented Sep 5, 2018

@NicholasBuse thanks, much appreciated!
If you guys would need more time with the build server, just ping me - I can continue making unofficial ones on my build server until your is ready.

@NicholasBuse NicholasBuse merged commit d49e6f7 into opengapps:master Sep 5, 2018
@NicholasBuse
Copy link
Contributor

@NicholasBuse NicholasBuse commented Sep 5, 2018

9.0 builds coming tonight...

Thanks @SpasilliumNexus!

@NicholasBuse
Copy link
Contributor

@NicholasBuse NicholasBuse commented Sep 6, 2018

I lied ...
... But they are coming tonight! (Build Server only got partially updated and did not execute 9.0 builds)

@SpasilliumNexus SpasilliumNexus deleted the SpasilliumNexus:android-9.0 branch Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.