Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improving testing and typehinting #77

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

slowy07
Copy link
Member

@slowy07 slowy07 commented Jul 17, 2024

improve typehingting and testing by adding some mark to skip testing function which is take to long, example:

test_aviris.py

# uncomment marker if testing download files
@pytest.mark.skip(reason="download takes long")
def test_download_file(self):
	self.assertTrue(os.path.exists(self.filepath))

reason use this mark:

sometimes developers or contributors use bad internet connection for development, so if cannot skip or passing will be takes too long for waiting the testing

doc screenshoots:
passing_pytest

Signed-off-by: slowy07 <slowy.arfy@proton.me>
@giswqs
Copy link
Member

giswqs commented Jul 17, 2024

Great improvement! Thank you.

@giswqs giswqs merged commit 6938393 into opengeos:main Jul 17, 2024
9 checks passed
@slowy07 slowy07 deleted the improvement-HyperCoast branch July 17, 2024 03:56
@slowy07
Copy link
Member Author

slowy07 commented Jul 17, 2024

thank u sir @giswqs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants