Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WCS 2.0.1 - Inconsistence between WCS Core and WCS Scaling Extension requirement #37

Closed
bangph opened this issue Feb 6, 2017 · 14 comments · Fixed by #128
Closed

WCS 2.0.1 - Inconsistence between WCS Core and WCS Scaling Extension requirement #37

bangph opened this issue Feb 6, 2017 · 14 comments · Fixed by #128
Assignees
Projects
Milestone

Comments

@bangph
Copy link

bangph commented Feb 6, 2017

So to test WCS 2.0.1 Core and Scale Extension, it needs to import some coverage to the entry service (at least: 2 types of coverage for WCS Core:

test_mean_summer_airtempRectifiedGridCoverage

test_mr
GridCoverage

then WCS Core can pass without any error. But WCS Scale Extension will have 1 error in Test wcs2:get-scal-req3-kvp

Message d1506e783_1:
[FAILURE] The service should offer at least one ReferenceableGridCoverage.

However, if add one ReferenceableGridCoverage before testing WCS Core, WCS Scale, e.g:

test_z_irr_cube_2ReferenceableGridCoverage

then WCS Core will failed due to ReferenceableGridCoverage only exists in GML 3.3 (not GML 3.2.1 and the schema validation is error).

Message d8936e2013_1:
[FAILURE] The response to a successful PostXML DescribeCoverage request with n>0 coverage identifiers shall be a list containing n items.

Request d8936e2023_1:
Method: get
URL: http://kahlua.eecs.jacobs-university.de/conformance?service=WCS&VERSION=2.0.1&request=DescribeCoverage&CoverageId=test_mean_summer_airtemp,test_z_irr_cube_2
Response from parser ctlp:XMLValidatingParser:

Messages from parser ctlp:XMLValidatingParser:
Validation error:
cvc-complex-type.2.4.a: Invalid content was found starting with element 'gmlrgrid:ReferenceableGridByVectors'. One of '{"http://www.opengis.net/gml/3.2":AbstractGeometry, "http://www.opengis.net/gml/3.2":AbstractTimeObject}' is expected.
1 validation error detected.

Message d8936e2075_1:
[FAILURE] The response to a successful PostXML DescribeCoverage request with n>0 coverage identifiers shall be a list containing n items.

Result: Failed

So It should be best to remove the requirement in Scale test for ReferenceableGridCoverage if WCS 2.0.1 will not use GML 3.3.

@bangph
Copy link
Author

bangph commented Feb 6, 2017

@bermud @keshav-nangare

@eshirschorn
Copy link

ReferenceableGridCoverage does not exist in GML 3.2.1. It exists only in GMLCOV 1.0 (renamed recently to CIS 1.0). Such disharmony issues are cleaned up via the candidate extension standard OGC 16-083r2, the CIS 1.0 ReferenceableGridCoverage Extension. It is a proper extension of CIS 1.0 and contains the 3 referenceable grid elements of GML 3.3 plus a 4th referenceable grid element for sensor model support via SensorML 2.0. Voting by the OGC TC will be completed on April 3, 2017.

@bangph
Copy link
Author

bangph commented Aug 7, 2017

@eshirschorn: The CIS is accepted by OGC, but these test will stay for long times for WCS 2.0.1, so for now, I could not run CITE test for WCS 2.0.1 combinations in one session (core, processcoverages, rangesubset and scale), but, 2 sessions (scale and another session for the rest of WCS extensions).

@lgoltz
Copy link
Contributor

lgoltz commented Nov 6, 2017

@bangph Can you please check if the error still occurs?
I've tested with TEAM Engine 4.10 and ETS Web Coverage Service (WCS) 2.0.1 (1.12) [1] and the service [1] (with the workaround described in #43 (comment))

The test wcs2:get-scal-req3-kvp is successful.

[1] http://cite.opengeospatial.org/teamengine/
[2] http://moon.planetserver.eu:8084/rasdaman/ows?service=WCS&request=GetCapabilities&acceptversions=2.0.1

@bangph
Copy link
Author

bangph commented Nov 6, 2017

@lgoltz this is different problem, you can see #37 (comment)

Basically, WCS 2.0.1 core does not support a ReferenceableGridCoverage but WCS 2.0.1 Scaling Extension wants to have one of this coverage type to test, which means, normally, I have to run test for WCS 2.0.1 core without test for Scaling and after that I will only run test Scaling extension from my work around in #43 (comment).

@lgoltz
Copy link
Contributor

lgoltz commented Nov 6, 2017

@bangph Thanks for clarification, I think I understand the problem now.
In the CTL scripts a can see that the test wcs2:get-scal-req3-kvp fails if a ReferenceableGridCoverage is not provided.

Which test fails in WCS 2.0.1 CORE if the ReferenceableGridCoverage is provided? Several test can fail with the message The response to a successful PostXML DescribeCoverage request with n>0 coverage identifiers shall be a list containing n items.
The GMLCOV 1.0 is already part of the project. Maybe we can enhance the validation to avoid the validation failure instead of removing (or simplifying) the test in SCALE EXT.

@bangph
Copy link
Author

bangph commented Nov 6, 2017

@lgoltz Any test cases in WCS 2.0.1 Core which invoke GML schema validator against WCS 2.0.1 schema will fail (and I think from test 1 - 20 it has this check).

@pebau
Copy link

pebau commented Nov 6, 2017

Likely the ReferenceableGridCoverage branch needs to be revisited in completeness - recently the "OGC Coverage Implementation Schema - ReferenceableGridCoverage Extension" [1] has been adopted. Maybe it's good to involve the spec editor, Eric Hirschorn, in discussions about a corresponding ETS for the new spec (that also would solve the issue discussed here I believe).

[1] http://docs.opengeospatial.org/is/16-083r2/16-083r2.html

@dstenger dstenger added this to In progress in CITE Apr 11, 2019
@dstenger dstenger moved this from In progress to To do in CITE Jun 6, 2019
@lgoltz lgoltz moved this from To do to Needs discussion in CITE Jun 12, 2019
@ghobona
Copy link
Contributor

ghobona commented Jun 22, 2023

@bangph Is this Issue still valid?

If so, could you please provide a link to a service so that we can reproduce the issue?

@ghobona ghobona moved this from Needs discussion to Waiting in CITE Jun 22, 2023
@bangph
Copy link
Author

bangph commented Jun 22, 2023

@ghobona this issue after 6 years is still there because WCS 2.0.1 core doesn't support ReferenceableGridCoverage coverage type.

Here is the endpoint http://conformance.rasdaman.com/rasdaman/ows?service=WCS&version=2.0.1&request=GetCapabilities which has test_irr_cube_1 coverage as ReferenceableGridCoverage.

The only solution here is as written 6 years ago is:

remove the requirement in Scale test for ReferenceableGridCoverage

@dstenger dstenger moved this from Waiting to In progress in CITE Jul 27, 2023
@dstenger dstenger assigned bpross-52n and unassigned dstenger, lgoltz and ghobona Jul 27, 2023
@bpross-52n
Copy link
Contributor

@bangph Just to be sure, if we would remove the requirement in Scale test for ReferenceableGridCoverage, you would have to remove the ReferenceableGridCoverage from the WCS, so that the core tests would also pass, right?

@bangph
Copy link
Author

bangph commented Aug 3, 2023

@bpross-52n even if you don't remove Scale test for ReferenceableGridCoverage (this exists in WCS Scaling extension) when I test WCS core, I still need to remove this testing ReferenceableGridCoverage coverage.

@dstenger
Copy link
Contributor

dstenger commented Aug 3, 2023

Thanks for the quick feedback.
So, the value of your proposed fix (remove the requirement in Scale test for ReferenceableGridCoverage) would be that you can remove ReferenceableGridCoverage and then pass both, Core and WCS Scaling extension, in the same test run?

@bangph
Copy link
Author

bangph commented Aug 3, 2023

@bpross-52n yes, correct, the idea of this ticket is to allow to pass core and Scaling extensions in the same run.

@bpross-52n bpross-52n mentioned this issue Aug 10, 2023
@dstenger dstenger assigned dstenger and unassigned bpross-52n Aug 18, 2023
@dstenger dstenger moved this from In progress to To verify in CITE Aug 18, 2023
@dstenger dstenger added this to the 1.20 milestone Aug 22, 2023
CITE automation moved this from To verify to Done Aug 22, 2023
dstenger added a commit that referenced this issue Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
CITE
  
Done
Development

Successfully merging a pull request may close this issue.

9 participants