New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improper use of mixed case column names in Data Column Constraints Table or View Definition #130

Closed
KRyden opened this Issue Aug 11, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@KRyden

KRyden commented Aug 11, 2015

The Geopackage specification has an inconsistency regarding the character casing of persistent Geopackage objects that needs to be corrected or clearly documented as an exception to avoid continued confusion. The issue is with column names cited in section 2.3.3.1.1 (Table 12) of the document.

Section 1.0 Base states:
The required capabilities specified in this clause serve as the base for options specified in clause 2 and extensions specified in clause 3. All gpkg_* tables and views and all tiles user data tables specified in this standard SHALL have only the specified columns and table constraints. Any features user data tables MAY have columns in addition to those specified. All specified table and column name values SHALL be lowercase.

Section 2.3.3.1.1 Table Definition
Table 12 Data Column Constraints Table or View Definition
This table contains two entries under Column Name that violate the explicit instructions in Section 1.0 that states column name values SHALL be lowercase (referenced above). Column names minIsInclusive and maxIsInclusive should be lowercase, not mixed case.

Implementation of this correction requires the following changes in the Geopackage specification (reference version 12-128r12_OGC Geopackage_Encoding_Standard_with_Corrigendum_2.pdf):

Section 2.3.3.1.1 Table Definition
Table 12 Data Column Constraints Table or View Definition
Column names minIsInclusive and maxIsInclusive should be lowercase, not mixed case (change to minisinclusive and maxisinclusive).

Section 2.3.3.1.2 Table Data Values
Req 65: minIsInclusive and maxIsInclusive should be changed to lowercase minisinclusive and maxisinclusive. Same update needs to happen in the test case for Req 65.
Req 66: minIsInclusive and maxIsInclusive should be changed to lowercase minisinclusive and maxisinclusive. Same update needs to happen in the test case for Req 66.

C.9 gpkg_data_column _constraints
Table 32 gpkg_data_column _constraints Table Definition SQL
Column names minIsInclusive and maxIsInclusive should be lowercase, not mixed case (change to minisinclusive and maxisinclusive).

@jyutzler jyutzler added this to the tiles-corrigendum milestone Aug 11, 2015

@jyutzler

This comment has been minimized.

Contributor

jyutzler commented Aug 18, 2015

In today's SWG we agreed to make these changes. To be consistent with other parts of the specification, we will use max_is_inclusive and min_is_inclusive.

This is a change in the specification so it will have to be highlighted as part of the release notes.

jyutzler added a commit to jyutzler/geopackage that referenced this issue Aug 26, 2015

@jyutzler jyutzler referenced this issue Aug 26, 2015

Merged

Casing #139

@jyutzler jyutzler closed this Aug 26, 2015

bradh added a commit to bradh/geopackage that referenced this issue Sep 25, 2015

Downcase description in gpkg_data_column_constraints
If we have a breaking change for this table(opengeospatial#130), lets finish the job.

@jyutzler jyutzler modified the milestones: tiles-corrigendum, 1.0.2 Nov 29, 2015

mrcnc pushed a commit to mrcnc/libgpkg that referenced this issue Mar 21, 2016

mrcnc pushed a commit to mrcnc/libgpkg that referenced this issue Mar 21, 2016

Marc Cenac
updating the column names to be in sync with spec
* see the related issue [here](opengeospatial/geopackage#130) for more info

mrcnc pushed a commit to mrcnc/libgpkg that referenced this issue Aug 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment