New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geopackage references to case sensitivty for views, triggers, constraints #131

Closed
KRyden opened this Issue Aug 11, 2015 · 0 comments

Comments

Projects
None yet
2 participants
@KRyden

KRyden commented Aug 11, 2015

The Geopackage specification allows properly formatted tables or views to be used interchangeably.

Section 1.0 Base states:

The required capabilities specified in this clause serve as the base for options specified in clause 2 and extensions specified in clause 3. All gpkg_* tables and views and all tiles user data tables specified in this standard SHALL have only the specified columns and table constraints. Any features user data tables MAY have columns in addition to those specified. All specified table and column name values SHALL be lowercase.

While implied by the paragraph as a whole, to avoid any ambiguity, the last sentence should be updated to explicitly call out both tables and views. The sentence should be changed to read as follows:

All specified table, view and column name values SHALL be lowercase.

A related issue exists in Section 2.3.2.1.1, Table 11 Data Columns Table or View Definition. While the rest of the Geopackage specification explicitly calls for the use of lowercase object names, the Column Description for the constraint_name column reads, "Case sensitive column value constraint name specified by reference to gpkg_data_column_constraints."

If you accept that triggers and constraints are logically database objects at the same level as tables, views, and column names, then the Geopackage specification should be consistent in requirements for case sensitivity of these objects. To address this issue, the following changes are proposed:

The last sentence of “Section 1.0 Base” should be changed to read as follows:

All specified table, view, column, trigger and constraint name values SHALL be lowercase.

Section 2.3.2.1.1 Table Definition
Table 11 Data Columns Table or View Definition
Column Description for the constraint_name column – should not reference a “Case sensitive value” –values SHALL be lowercase.

Section 2.3.2.1.2 Table Data Values
Req 59: constraint_name should not reference a “Case sensitive value” –values SHALL be lowercase.

Section 2.3.3.1.1 Table Definition
Table 12 Data Column Constraints Table or View Definition
Column Description for the constraint_name column – should not reference a “Case sensitive value” –values SHALL be lowercase.

@jyutzler jyutzler added this to the tiles-corrigendum milestone Aug 11, 2015

jyutzler added a commit to jyutzler/geopackage that referenced this issue Aug 26, 2015

@jyutzler jyutzler referenced this issue Aug 26, 2015

Merged

Casing #139

@jyutzler jyutzler closed this Aug 26, 2015

@jyutzler jyutzler modified the milestones: tiles-corrigendum, 1.0.2 Nov 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment