Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing close-parens in Annex M (geometry type trigger extension) #152

Closed
TheDorkKnight opened this issue Oct 19, 2015 · 1 comment
Closed
Milestone

Comments

@TheDorkKnight
Copy link

@TheDorkKnight TheDorkKnight commented Oct 19, 2015

See pull request 151 for my proposed fix.

The template SQL for creating geometry type triggers is missing a closing parenthesis for both the INSERT and the UPDATE trigger definitions.

Implementers of Annex M have noticed this and have added the missing parentheses. See libspatialite (as of version 4.3.0a) for an example. They have implemented Annex M in src/geopackage/gpkg_add_geometry_triggers.c

@jyutzler
Copy link
Contributor

@jyutzler jyutzler commented Oct 20, 2015

fixed via #151

@jyutzler jyutzler closed this Oct 20, 2015
@jyutzler jyutzler added this to the 1.0.2 milestone Nov 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants