New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistent use of min/max is inclusive #260

Closed
KRyden opened this Issue Oct 17, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@KRyden

KRyden commented Oct 17, 2016

At revision 1.1, the mixed case MinIsInclusive and MaxIsInclusive were changed to all lower case- the document now contains two different column references for each:

minisinclusive/min_is_inclusive
maxisinclusive/max_is_inclusive

This needs to be corrected - all lower case is the change that was to be made.

@jyutzler

This comment has been minimized.

Contributor

jyutzler commented Oct 17, 2016

@KRyden I am only seeing minisinclusive in the abstract tests. That is a pretty easy fix.
Do you see it anywhere else?

@KRyden

This comment has been minimized.

KRyden commented Oct 17, 2016

That’s the only place I see it as well. Simple editorial fix should suffice.

Keith

From: Jeff Yutzler [mailto:notifications@github.com]
Sent: Monday, October 17, 2016 9:41 AM
To: opengeospatial/geopackage geopackage@noreply.github.com
Cc: Keith Ryden kryden@esri.com; Mention mention@noreply.github.com
Subject: Re: [opengeospatial/geopackage] inconsistent use of min/max is inclusive (#260)

@KRydenhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_KRyden&d=DQMCaQ&c=n6-cguzQvX_tUIrZOS_4Og&r=tvLPjeMfOs5jYGz-2NsVow&m=6sip7lsmeQeP18iADu4IKQCufF0pGZD3XEzhevw-msc&s=8w9fBBOtOsLhYraSPz3w0RGLuSu42YY5aD_6swF25HY&e= I am only seeing minisinclusive in the abstract tests. That is a pretty easy fix.
Do you see it anywhere else?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_opengeospatial_geopackage_issues_260-23issuecomment-2D254262469&d=DQMCaQ&c=n6-cguzQvX_tUIrZOS_4Og&r=tvLPjeMfOs5jYGz-2NsVow&m=6sip7lsmeQeP18iADu4IKQCufF0pGZD3XEzhevw-msc&s=NcESR9P9c-BpUxq6bGUNxwKt-qivyVi1VLrDNmrswgU&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ACCGBDjqnTu8gBjZ7IKna1QSOmpT108eks5q06U4gaJpZM4KYy5Y&d=DQMCaQ&c=n6-cguzQvX_tUIrZOS_4Og&r=tvLPjeMfOs5jYGz-2NsVow&m=6sip7lsmeQeP18iADu4IKQCufF0pGZD3XEzhevw-msc&s=JyEbuqEwkOX2fk9KErxl68L5KMwd_KD6zQGVpPE7r9k&e=.

@jyutzler jyutzler added this to the 1.2 milestone Oct 18, 2016

jyutzler added a commit that referenced this issue Oct 18, 2016

Merge pull request #263 from jyutzler/i260
min/max_is_inclusive #260

@jyutzler jyutzler closed this Oct 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment